Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remaining instances of ArithmeticError: 0^0 is undefined #13786

Closed
orlitzky opened this issue Dec 2, 2012 · 19 comments
Closed

Fix remaining instances of ArithmeticError: 0^0 is undefined #13786

orlitzky opened this issue Dec 2, 2012 · 19 comments

Comments

@orlitzky
Copy link
Contributor

orlitzky commented Dec 2, 2012

Some of these were fixed in #10772, but a few remain. Find/grep show,

  • ./rings/padics/padic_capped_relative_element.pyx
  • ./rings/padics/padic_fixed_mod_element.pyx
  • ./rings/padics/padic_ZZ_pX_CR_element.pyx
  • ./rings/padics/padic_ZZ_pX_FM_element.pyx

Unless any of these are special (for whatever reason), we should return 1 instead from the appropriate ring.

See also: #13894, #13895, #13897, #13941.

CC: @kcrisman

Component: algebra

Author: Michael Orlitzky

Reviewer: Travis Scrimshaw

Merged: sage-5.8.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13786

@orlitzky orlitzky added this to the sage-5.8 milestone Dec 2, 2012
@orlitzky

This comment has been minimized.

@orlitzky

This comment has been minimized.

@orlitzky

This comment has been minimized.

@orlitzky
Copy link
Contributor Author

Dependencies: #13940

@orlitzky

This comment has been minimized.

@orlitzky
Copy link
Contributor Author

Changed dependencies from #13940 to #13894, #13895, #13897, #13940, #13941

@tscrim
Copy link
Collaborator

tscrim commented Jan 29, 2013

comment:8

Just a general statement on the documentation in these patches. I'd prefer to see the 0^0 formatted either in latex `0^0` (which would display as 00) or as a code literal ``0^0``.

Thanks,

Travis

@orlitzky
Copy link
Contributor Author

comment:9

I finally added double backticks to the other patches. While those functions aren't in the reference manual, they should and hopefully someday will be.

@tscrim
Copy link
Collaborator

tscrim commented Feb 22, 2013

comment:10

Thank you. It suppose to make the docreader (which may only really be me) understand that it is suppose to be code/input.

Also, for the remaining ones in the padics, could you just put them all in one patch (possibly on this ticket)?

Thanks,

Travis

@orlitzky

This comment has been minimized.

@orlitzky
Copy link
Contributor Author

comment:11

Attachment: sage-trac_13786.patch.gz

Patch is up. I had split them initially to make it easier for (potentially) multiple reviewers. Thanks for taking a look at all of them.

I've removed ntl_lzz_p.pyx from the list per #13940. This patch should take care of the remaining four.

@orlitzky
Copy link
Contributor Author

Author: Michael Orlitzky

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2013

comment:13

Looks good to me. Thank you.

Travis

@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2013

Reviewer: Travis Scrimshaw

@jdemeyer jdemeyer removed this from the sage-5.8 milestone Feb 26, 2013
@tscrim
Copy link
Collaborator

tscrim commented Feb 26, 2013

comment:15

Replying to @orlitzky:

I've removed ntl_lzz_p.pyx from the list per #13940. This patch should take care of the remaining four.

Does this depend on #13940 anymore?

@orlitzky

This comment has been minimized.

@orlitzky
Copy link
Contributor Author

Changed dependencies from #13894, #13895, #13897, #13940, #13941 to none

@orlitzky
Copy link
Contributor Author

comment:16

No, good catch. I've removed all of the dependencies; no need to confuse things. This patch can be merged without any of those. If an archaeologist is curious, he can check the description diff.

@jdemeyer jdemeyer added this to the sage-5.8 milestone Feb 27, 2013
@jdemeyer jdemeyer removed the pending label Feb 27, 2013
@jdemeyer
Copy link

Merged: sage-5.8.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants