New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remaining instances of ArithmeticError: 0^0 is undefined #13786
Comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dependencies: #13940 |
This comment has been minimized.
This comment has been minimized.
comment:8
Just a general statement on the documentation in these patches. I'd prefer to see the Thanks, Travis |
comment:9
I finally added double backticks to the other patches. While those functions aren't in the reference manual, they should and hopefully someday will be. |
comment:10
Thank you. It suppose to make the docreader (which may only really be me) understand that it is suppose to be code/input. Also, for the remaining ones in the padics, could you just put them all in one patch (possibly on this ticket)? Thanks, Travis |
This comment has been minimized.
This comment has been minimized.
comment:11
Attachment: sage-trac_13786.patch.gz Patch is up. I had split them initially to make it easier for (potentially) multiple reviewers. Thanks for taking a look at all of them. I've removed ntl_lzz_p.pyx from the list per #13940. This patch should take care of the remaining four. |
Author: Michael Orlitzky |
comment:13
Looks good to me. Thank you. Travis |
Reviewer: Travis Scrimshaw |
This comment has been minimized.
This comment has been minimized.
comment:16
No, good catch. I've removed all of the dependencies; no need to confuse things. This patch can be merged without any of those. If an archaeologist is curious, he can check the description diff. |
Merged: sage-5.8.beta2 |
Some of these were fixed in #10772, but a few remain. Find/grep show,
Unless any of these are special (for whatever reason), we should return
1
instead from the appropriate ring.See also: #13894, #13895, #13897, #13941.
CC: @kcrisman
Component: algebra
Author: Michael Orlitzky
Reviewer: Travis Scrimshaw
Merged: sage-5.8.beta2
Issue created by migration from https://trac.sagemath.org/ticket/13786
The text was updated successfully, but these errors were encountered: