Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-organize number field element inheritance hierarchy #1385

Closed
robertwb opened this issue Dec 3, 2007 · 3 comments
Closed

Re-organize number field element inheritance hierarchy #1385

robertwb opened this issue Dec 3, 2007 · 3 comments
Assignees
@loefflerd
Labels
c: number fields r: invalid t: enhancement

Comments

@robertwb
Copy link
Contributor

robertwb commented Dec 3, 2007

Currently the base NumberFieldElement class requires NTL. However, the quadratic number field elements, and (in the future) FLINT-based number field classes won't use NTL at all, but things need to be split out to make this clean.

Component: number fields

Reviewer: Jeroen Demeyer, David Loeffler

Issue created by migration from https://trac.sagemath.org/ticket/1385
@sagetrac-mabshoff sagetrac-mabshoff mannequin added this to the sage-2.9 milestone Dec 4, 2007
@loefflerd loefflerd mannequin assigned loefflerd and unassigned williamstein Jul 20, 2009
@jdemeyer
Copy link

jdemeyer commented Oct 9, 2011

comment:4

I don't see any reason to change things at the moment. If we really re-implement number fields, that would be the correct time to change this. Proposing to close as "wontfix".

@jdemeyer jdemeyer removed this from the sage-4.7.2 milestone Oct 9, 2011
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Oct 9, 2011

comment:5

I agree. Let's close this.

@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Oct 9, 2011

Reviewer: Jeroen Demeyer, David Loeffler

@jdemeyer jdemeyer closed this as completed Oct 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@loefflerd loefflerd

Labels
c: number fields r: invalid t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@robertwb @aghitza @williamstein @jdemeyer