Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sage-make_relative when upgrading #14027

Closed
jdemeyer opened this issue Jan 28, 2013 · 7 comments
Closed

Disable sage-make_relative when upgrading #14027

jdemeyer opened this issue Jan 28, 2013 · 7 comments

Comments

@jdemeyer
Copy link

This is essentially #13407 for upgrades: sage-make_relative is evil because it leads to race conditions.

This probably caused an upgrade problem on rosemary: the script local/bin/ipython wasn't installed:

running install_scripts
copying build/scripts-2.7/iplogger -> /home/buildbot/build/sage/rosemary-1/rosemary_upgrade_4.5.2/build/sage-5.7.beta1/local/bin

which normally looks like

running install_scripts
copying build/scripts-2.7/ipengine -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipcontroller -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipcluster -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/iplogger -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/ipython -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/pycolor -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/irunner -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin
copying build/scripts-2.7/iptest -> /release/buildbot/sage/sage-1/sage_upgrade_4.8/build/sage-5.7.beta1/local/bin

Distutils by default doesn't overwrite newer files, and sage-make_relative can make a file look newer, causing distutils to not copy a file.

Component: build

Author: Jeroen Demeyer

Reviewer: Volker Braun

Merged: sage-5.7.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14027

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Attachment: 14027_dont_make_relative.patch.gz

@vbraun
Copy link
Member

vbraun commented Jan 28, 2013

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Jan 28, 2013

comment:4

Sounds good to me.

@jdemeyer
Copy link
Author

Merged: sage-5.7.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants