New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ChomP to latest upstream version (compilation failure) #14076
Comments
comment:2
The required fixes seem to be included in the current version 2013-01-02 of the CHomP package, so an update should fix this issue. |
Author: Volker Braun |
Dependencies: #14595 |
comment:3
With #14595 this leads to the following doctest failure --- which notation do we prefer for the homology groups?
|
This comment has been minimized.
This comment has been minimized.
comment:5
Also, this blows up in your face:
No its not!
Its a bit of a variant of #14578: caching for mutable objects is fragile. Its difficult to get right, and even if you do you'll break it when you make changes in the future. The right thing to do is to make cell complexes immutable, and |
comment:6
I certainly agree that the Regarding "With #14595 this leads to the following doctest failure --- which notation do we prefer for the homology groups?" I have a slight preference for
but I don't feel strongly about it. |
comment:7
By the way, the immutability issue was discussed here, where there were objections to making complexes immutable. |
comment:8
If we are going to do this, we should also make |
comment:9
I have the same installation problem as originally reported with SuSE when using Sage 5.10 on OS X. Sage ships with its own version of gcc on this platform (currently 4.7.3), so any OS X user with Sage 5.10 will experience this issue as well if they try to install Chomp. I tried the updated Chomp package at the above link and it installed and works fine. |
Updated patch |
comment:10
Attachment: trac_14076_chomp_update.patch.gz Ok I added a patch that fixes the trivial doctest failure and un-caches the Ready for review... |
comment:11
The answers given by CHomP and Sage without CHomP for the homology generators of
With CHomP:
As far as I can tell, the non-CHomP answer is correct: (1,0,0) generates a copy of |
comment:12
By the way, in order to make simplicial complexes unique, do we need to deprecate |
comment:13
Making simplicial complexes immutable isn't something that can be done gradually, so code that relies on them being mutable will necessarily break. Having said that, I never was very fond of the I agree that components of the torsion generator are reversed, will have a look at that. |
comment:14
ChomP actually uses
|
comment:15
Right, I have a patch for this, coming up. |
comment:16
Okay, here's a patch which sorts the list of generators so it matches the sorted list of abelian group invariants. It also fixes one bug (a missing argument in a call to |
Reviewer: John Palmieri |
Attachment: trac_14076-more-chomp-fixes.patch.gz apply second |
comment:17
By the way, I'm happy with your patch. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:19
Doctests pass for me, looks good! |
This comment has been minimized.
This comment has been minimized.
comment:20
spkg landed in optional on the server/mirrors and the older experimental one is gone (thx for the history lesson, at least i never got notified about this) |
comment:21
Thanks, Harald. Just to be clear, my message was purely informational, absolutely no criticism was intended. I assumed that no one had told you before, and this upgrade to the spkg was a good time to take care of it. |
comment:22
language barrier alert. i didn't mean it that way ;-) |
comment:23
(I didn't think so, but I wanted to be clear.) |
comment:24
There are a few very minor issues with the spkg that I didn't catch. Follow-up ticket: #14872. |
Merged: sage-5.11.rc0 |
Currently (Sage 5.7.beta3) on
OpenSuse 12.2
with gcc version 4.7.1 20120723 the CHomP package (version chomp-20100213.p2) can't be installed. This is all fixed in the latest upstream version.Updated optional spkg: http://boxen.math.washington.edu/home/vbraun/spkg/chomp-20130518.p0.spkg
By the way, this should be added to the optional spkgs, not the experimental ones (and the old one should be removed from the experimental list): there was a vote on this in sage-devel over two years ago to make this change, but I think it never happened.
Apply to the Sage library:
Depends on #14595
CC: @jhpalmieri @tscrim @haraldschilly
Component: packages: optional
Author: Volker Braun
Reviewer: John Palmieri
Merged: sage-5.11.rc0
Issue created by migration from https://trac.sagemath.org/ticket/14076
The text was updated successfully, but these errors were encountered: