Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quasisymmetric_inject_shorthands help file improved #14109

Closed
sagetrac-billey mannequin opened this issue Feb 13, 2013 · 14 comments
Closed

Quasisymmetric_inject_shorthands help file improved #14109

sagetrac-billey mannequin opened this issue Feb 13, 2013 · 14 comments

Comments

@sagetrac-billey
Copy link
Mannequin

sagetrac-billey mannequin commented Feb 13, 2013

Help file for all inject shorthands is incomplete. We propose improving this with a specific example from quasisymmetric functions

CC: @sagetrac-chrisjamesberg

Component: combinatorics

Keywords: quasisymmetric function

Author: Sara Billey

Branch/Commit: 01e0fdf

Reviewer: Travis Scrimshaw, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/14109

@sagetrac-billey sagetrac-billey mannequin added this to the sage-5.11 milestone Feb 13, 2013
@sagetrac-billey sagetrac-billey mannequin self-assigned this Feb 13, 2013
@sagetrac-billey
Copy link
Mannequin Author

sagetrac-billey mannequin commented Feb 13, 2013

patch

@jdemeyer
Copy link

comment:1

Attachment: inject_shorthands_documentation.patch.gz

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2013

Changed author from billey to Sara Billey

@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2013

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Aug 16, 2013

comment:2

Hey Sara,

Is this ready for review? If so, could you please set it to needs_review, and I'll do the review.

Best,

Travis

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@fchapoton
Copy link
Contributor

Branch: u/chapoton/14109

@fchapoton
Copy link
Contributor

comment:6

I have made a git branch.

I assume that this is "needs review"


New commits:

277c2aaThis is adding a small change to the documentation for the method inject_shorthands.
48cc859trac #14109 doctest pass

@fchapoton
Copy link
Contributor

Commit: 48cc859

@fchapoton
Copy link
Contributor

comment:7

The new doc INPUT does not match the function..

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2015

Changed commit from 48cc859 to 01e0fdf

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 19, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

6dcedf1Merge branch 'u/chapoton/14109' into 6.6.b0
01e0fdftrac #14109 correct input field

@fchapoton fchapoton removed this from the sage-6.4 milestone Feb 19, 2015
@fchapoton fchapoton added this to the sage-6.6 milestone Feb 19, 2015
@tscrim
Copy link
Collaborator

tscrim commented Feb 19, 2015

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton

@tscrim
Copy link
Collaborator

tscrim commented Feb 19, 2015

comment:11

LGTM.

@vbraun
Copy link
Member

vbraun commented Feb 21, 2015

Changed branch from u/chapoton/14109 to 01e0fdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants