Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making mutable copies of simplicial complexes #14142

Closed
tscrim opened this issue Feb 16, 2013 · 9 comments
Closed

Making mutable copies of simplicial complexes #14142

tscrim opened this issue Feb 16, 2013 · 9 comments
Assignees
@tscrim
Labels
c: algebraic topology p: major / 3 t: bug
Milestone
sage-5.8

Comments

@tscrim
Copy link
Collaborator

tscrim commented Feb 16, 2013

After #12587, one could make simplicial complexes immutable in order for them to be hashable. However there was no functionality to make mutable copies.

CC: @jhpalmieri

Component: algebraic topology

Keywords: mutable copy simplicial complex

Author: Travis Scrimshaw

Reviewer: John Palmieri

Merged: sage-5.8.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14142
@tscrim tscrim added this to the sage-5.8 milestone Feb 16, 2013
@tscrim tscrim self-assigned this Feb 16, 2013
@tscrim

This comment has been minimized.

Sign in to view
@jhpalmieri
Copy link
Member

comment:3

This looks pretty good. I think it should be documented in one more place, maybe in the top-level docstring, in the mutability section, say around line 133.

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 26, 2013

comment:4

I've added the doctests you requested.

Best,

Travis

@jhpalmieri
Copy link
Member

comment:5

Great. Change "a mutable copies" (line 135) and I'll give it a positive review.

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 26, 2013

comment:6

Done. I also changed the hash test to a better formatted test.

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 26, 2013

Attachment: trac_14142-mutable_copy_simplicial-ts.patch.gz

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@tscrim
Copy link
Collaborator Author

tscrim commented Feb 26, 2013

comment:8

Thank you for the review.

@jdemeyer
Copy link

Merged: sage-5.8.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tscrim tscrim

Labels
c: algebraic topology p: major / 3 t: bug
Projects
None yet
Milestone
sage-5.8
Development

No branches or pull requests
3 participants
@tscrim @jhpalmieri @jdemeyer