gap_reset_workspace can fail if directory is missing

[vbraun]

As reported on sage-devel (https://groups.google.com/d/topic/sage-devel/K1ytSY-3Uro/discussion)

I tried "./sage -i database_gap" but it died with an error:

Installed tomlib database.
Traceback (most recent call last):
  File "/.../sage-5.7/local/bin/sage-eval", line 14, in <module>
    eval(compile(s,'<cmdline>','exec'))
  File "<cmdline>", line 1, in <module>
  File "/.../sage-5.7/local/lib/python2.7/site-packages/sage/interfaces/gap.py", line 1465, in gap_reset_workspace
    for F in os.listdir(GAP_DIR):
OSError: [Errno 2] No such file or directory: '/home/NewUser/.sage/gap'
(...)

Apply

• attachment: 14171_missing_gap_dir.patch​
• attachment: 14171_fix_long_time.patch​

Component: interfaces

Author: Jeroen Demeyer, Volker Braun

Reviewer: Volker Braun, Jeroen Demeyer

Merged: sage-5.12.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14171

[jdemeyer]

comment:1

Working on trivial patch...

[jdemeyer]

comment:2

Attachment: 14171_missing_gap_dir.patch.gz

[jdemeyer]

Author: Jeroen Demeyer

[vbraun]

Initial patch

[vbraun]

comment:3

Attachment: 14171_fix_long_time.patch.gz

The short (not --long) doctest fails because gap_reset_workspace() is not called yet the existence of a newly-created workspace is checked. Fixed in reviewer patch.

Edit: obviously positive review to Jeroen's patch.

[vbraun]

Changed author from Jeroen Demeyer to Jeroen Demeyer, Volker Braun

[vbraun]

Reviewer: Volker Braun

[jdemeyer]

Changed reviewer from Volker Braun to Volker Braun, Jeroen Demeyer

[jdemeyer]

Merged: sage-5.12.beta1