New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase harcoded timeouts default values #14179
Comments
comment:1
Here comes a patch for the Sage library part. |
comment:2
(Note the patch name says 14719, but fortunately the commit message states the correct ticket number, so I won't upload another patch, unless modifications are needed of course.) |
comment:3
For sagenb: sagemath/sagenb#137 |
comment:4
Replying to @kini:
Great, thanx! |
Upstream: Fixed upstream, in a later stable release. |
comment:5
Patchbot, apply trac_14719-sage_library.patch |
comment:6
The notebook fix is in version 0.10.5 and upgrading to this version is #14330. |
This comment has been minimized.
This comment has been minimized.
Author: Jean-Pierre Flori |
Dependencies: #14330 |
Changed dependencies from #14330 to none |
Reviewer: Jeroen Demeyer |
comment:7
This doesn't actually depend on #14330. |
Work Issues: rebase |
comment:8
And it needs to be rebased to #12415. |
Changed work issues from rebase to none |
comment:9
Attachment: trac_14179-sage_library.patch.gz |
This comment has been minimized.
This comment has been minimized.
comment:10
In fact I'm not sure what needed to be rebased. |
comment:11
Oh, is that the 'r' before '"""'... |
Merged: sage-5.9.beta4 |
Two hardcoded timeouts default valued make some tests fail on Cygwin (presumably because Cygwin is slow, and forking is horribly slow):
See #6743 comment:144 and #6743 comment:146
Just slightly (from a human point of view) increasing these values let the tests pass on recent and even not so recent and powerful harware running Cygwin, so let's increase these default values unconditionnally rather than adding Cygwin specific code, or warnings about expected to fail tests or whatever; let's say:
Apply:
Upstream: Fixed upstream, in a later stable release.
CC: @jdemeyer @kcrisman @dimpase
Component: porting: Cygwin
Keywords: cygwin timeout
Author: Jean-Pierre Flori
Reviewer: Jeroen Demeyer
Merged: sage-5.9.beta4
Issue created by migration from https://trac.sagemath.org/ticket/14179
The text was updated successfully, but these errors were encountered: