Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary replication of Code in sage/logic/boolformula.py #14183

Closed
KPanComputes opened this issue Feb 26, 2013 · 4 comments
Closed

Unnecessary replication of Code in sage/logic/boolformula.py #14183

KPanComputes opened this issue Feb 26, 2013 · 4 comments
Assignees
@burcin
Labels
c: symbolics p: major / 3
Milestone
sage-5.9

Comments

@KPanComputes
Copy link

The functions convert_cnf is simply the function convert_cnf_table. Although, this has been acknowledged in the docstring, the very implementation seems out of the way. We usually, declare the functions equal instead of having different docstrings and such. So, I have done this in this case with minor tweaks in the documentation.

Component: symbolics

Keywords: logic

Author: Kannappan Sampath

Reviewer: Punarbasu Purkayastha

Merged: sage-5.9.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14183
@KPanComputes KPanComputes added this to the sage-5.9 milestone Feb 26, 2013
@KPanComputes
Copy link
Author

comment:1

Attachment: trac_14183_aliasing.patch.gz

@ppurka
Copy link
Member

ppurka commented Mar 17, 2013

Reviewer: Punarbasu Purkayastha

@ppurka
Copy link
Member

ppurka commented Mar 17, 2013

comment:2

Looks good to me and passes all doctests @patchbot.

@jdemeyer
Copy link

Merged: sage-5.9.beta1

@sagetrac-mvngu sagetrac-mvngu mannequin mentioned this issue Dec 5, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burcin burcin

Labels
c: symbolics p: major / 3
Projects
None yet
Milestone
sage-5.9
Development

No branches or pull requests
4 participants
@burcin @ppurka @jdemeyer @KPanComputes