Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean-up of parts of combinat #14216

Closed
fchapoton opened this issue Mar 3, 2013 · 5 comments
Closed

clean-up of parts of combinat #14216

fchapoton opened this issue Mar 3, 2013 · 5 comments
Assignees
@sagetrac-sage-combinat
Labels
c: combinatorics p: minor / 4 t: enhancement
Milestone
sage-5.8

Comments

@fchapoton
Copy link
Contributor

Here is a small patch that

  • removes duplicate or unused imports
  • changes the raise syntax to Python 3 syntax
  • removes unused variables

in a few combinat files

CC: @sagetrac-sage-combinat

Component: combinatorics

Keywords: clean-up

Author: Frédéric Chapoton

Reviewer: Nathann Cohen

Merged: sage-5.8.beta3

Issue created by migration from https://trac.sagemath.org/ticket/14216
@fchapoton fchapoton added this to the sage-5.8 milestone Mar 3, 2013
@fchapoton
Copy link
Contributor Author

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor Author

comment:1

Attachment: trac-14216-combinat-small-cleanup-fc.patch.gz

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 5, 2013

comment:2

Makes sense, passes tests, good to go ! The only problem with this ticket is that it should be named "clean up parts of combinat 1/3457", because there is that much left to do :-P

Cc me if you write any other such ticket !

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Mar 5, 2013

Reviewer: Nathann Cohen

@jdemeyer
Copy link

jdemeyer commented Mar 6, 2013

Merged: sage-5.8.beta3

@jdemeyer jdemeyer closed this as completed Mar 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-sage-combinat sagetrac-sage-combinat

Labels
c: combinatorics p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-5.8
Development

No branches or pull requests
2 participants
@jdemeyer @fchapoton