Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for sagenb pull request 84 #14273

Closed
roed314 opened this issue Mar 14, 2013 · 11 comments
Closed

Remove workaround for sagenb pull request 84 #14273

roed314 opened this issue Mar 14, 2013 · 11 comments

Comments

@roed314
Copy link
Contributor

roed314 commented Mar 14, 2013

In #12415 we added

# Workarounds for https://github.com/sagemath/sagenb/pull/84
import sagenb.notebook.misc
import sagenb.notebook.sage_email
def fixed_default_email_address():
    import socket
    import getpass
    return getpass.getuser() + "@" + socket.gethostname()
sagenb.notebook.sage_email.default_email_address = fixed_default_email_address

to sage.doctest.forker. These whould be removed once the newer version of sagenb is incorporated into Sage.

Depends on #12415
Depends on #14330
Depends on #14266

CC: @kini @jdemeyer

Component: doctest framework

Author: R. Andrew Ohana

Branch: u/tkluck/ticket/14273

Reviewer: Jeroen Demeyer, Punarbasu Purkayastha

Merged: sage-5.12.beta0

Issue created by migration from https://trac.sagemath.org/ticket/14273

@jdemeyer
Copy link

Changed dependencies from #12415 to #12415, #14330

@ohanar
Copy link
Member

ohanar commented Apr 10, 2013

Author: R. Andrew Ohana

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

comment:4

Assuming that sagemath/sagenb#84 is merged, this patch is obviously fine.

@jdemeyer jdemeyer removed this from the sage-5.9 milestone Apr 10, 2013
@jdemeyer
Copy link

jdemeyer commented Jun 8, 2013

apply to sage library

@jdemeyer
Copy link

jdemeyer commented Jun 8, 2013

Changed dependencies from #12415, #14330 to #12415, #14330, #14266

@jdemeyer
Copy link

jdemeyer commented Jun 8, 2013

comment:5

Attachment: trac14273.patch.gz

Rebased to #14266 and removed an additional workaround in sage/doctests/control.py

@jdemeyer jdemeyer added this to the sage-5.11 milestone Jun 14, 2013
@jdemeyer jdemeyer removed the pending label Jun 14, 2013
@ppurka
Copy link
Member

ppurka commented Jun 30, 2013

comment:8

These changes were apparently used as workarounds for the old sagenb in #12415. I ran the following

...allations/sage-5.11.beta3» ./sage -btp 2 --sagenb

and all the tests passed. So, removing this workaround looks ok to me now.

@ppurka
Copy link
Member

ppurka commented Jun 30, 2013

Changed reviewer from Jeroen Demeyer to Jeroen Demeyer, Punarbasu Purkayastha

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Jul 21, 2013
@tkluck
Copy link

tkluck commented Jul 23, 2013

Branch: u/tkluck/ticket/14273

@jdemeyer
Copy link

jdemeyer commented Aug 2, 2013

Merged: sage-5.12.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants