Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove explict references to SAGE_ROOT in docbuilding #14316

Closed
ohanar opened this issue Mar 19, 2013 · 5 comments
Closed

remove explict references to SAGE_ROOT in docbuilding #14316

ohanar opened this issue Mar 19, 2013 · 5 comments
Assignees
@sagetrac-GeorgSWeber
Labels
c: build p: major / 3
Milestone
sage-5.9

Comments

@ohanar
Copy link
Member

ohanar commented Mar 19, 2013

There are some unnecessary explicit references to SAGE_ROOT in the docbuilder, now that we have sage/env.py, let's remove them. (This will fix building the documentation after transitioning to the git layout.)

Apply:

Component: build

Author: R. Andrew Ohana

Reviewer: Robert Bradshaw

Merged: sage-5.9.beta3

Issue created by migration from https://trac.sagemath.org/ticket/14316
@ohanar ohanar added this to the sage-5.9 milestone Mar 19, 2013
@ohanar
Copy link
Member Author

ohanar commented Mar 19, 2013

Attachment: trac14316.patch.gz

apply to sage library

@ohanar

This comment has been minimized.

Sign in to view
@robertwb
Copy link
Contributor

comment:2

LGTM, pending patchbot passing all tests/docbuild.

@jdemeyer
Copy link

Reviewer: Robert Bradshaw

@jdemeyer
Copy link

jdemeyer commented Apr 1, 2013

Merged: sage-5.9.beta3

@jdemeyer jdemeyer closed this as completed Apr 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-GeorgSWeber sagetrac-GeorgSWeber

Labels
c: build p: major / 3
Projects
None yet
Milestone
sage-5.9
Development

No branches or pull requests
3 participants
@robertwb @ohanar @jdemeyer