More doctests from the book "Calcul mathématique avec Sage" chapter "integration" #14318

sagetrac-lfousse · 2013-03-20T04:38:21Z

The attached file provides doctests for examples in the chapter on integration and differential equations. Tests pass with 5.11.

Apply only attachment: trac_14318_doctests_from_french_book.patch

Component: doctest coverage

Author: Laurent Fousse, Paul Zimmermann, Frédéric Chapoton

Branch/Commit: u/chapoton/14318 @ 91f4bcb

Reviewer: Frédéric Chapoton, Paul Zimmermann

Issue created by migration from https://trac.sagemath.org/ticket/14318

The text was updated successfully, but these errors were encountered:

sagetrac-lfousse · 2013-03-20T04:38:37Z

Attachment: integration_doctest.sage.gz

jdemeyer · 2013-04-09T14:24:47Z

comment:2

What am I supposed to do with this file? Normally, additions to Sage are patches to the Sage library (in devel/sage). See http://sagemath.org/doc/developer/

zimmermann6 · 2013-08-23T11:45:43Z

comment:5

I've made a proper patch. All tests pass with Sage 5.11. Ready for review.

Paul

zimmermann6 · 2013-08-23T11:45:43Z

Author: Laurent Fousse, Paul Zimmermann

fchapoton · 2013-08-30T12:18:00Z

comment:6

ok, looks good to me

fchapoton · 2013-08-30T12:18:00Z

Reviewer: Frédéric Chapoton

zimmermann6 · 2013-08-31T08:44:30Z

comment:9

thank you Frédéric.

Paul

jdemeyer · 2013-09-02T10:09:00Z

comment:10

Some of these examples yield slightly different results on 32-bit systems:

sage -t --long devel/sage/sage/tests/french_book/integration_doctest.py
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 30, in sage.tests.french_book.integration_doctest
Failed example:
    N(integrate(exp(-x^2)*log(x), x, 17, 42))
Expected:
    2.5657285006962035e-127
Got:
    2.565728500696221e-127
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 42, in sage.tests.french_book.integration_doctest
Failed example:
    numerical_integral(exp(-x^2)*log(x), 17, 42)
Expected:
    (2.5657285006962035e-127, 3.3540254049238093e-128)
Got:
    (2.565728500696221e-127, 3.3540254049023843e-128)
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 49, in sage.tests.french_book.integration_doctest
Failed example:
    numerical_integral(exp(-x^100), 0, 1.1, algorithm='qng')
Expected:
    (0.994327538576531..., 0.016840666914688864)
Got:
    (0.9943275385765319, 0.016840666914705607)
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 59, in sage.tests.french_book.integration_doctest
Failed example:
    N(integrate(exp(-x^2)*log(x), x, 17, 42), 200)
Expected:
    2.5657285006962035e-127
Got:
    2.565728500696221e-127
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 80, in sage.tests.french_book.integration_doctest
Failed example:
    gp('intnum(x=17, 42, exp(-x^2)*log(x))')
Expected:
    2.5657285005610514829173563961304785900 E-127
Got:
    2.565728500561051482917356396 E-127
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 85, in sage.tests.french_book.integration_doctest
Failed example:
    gp('intnum(x=0, 1, sin(sin(x)))')
Expected:
    0.43060610312069060491237735524846578643
Got:
    0.4306061031206906049123773553
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 94, in sage.tests.french_book.integration_doctest
Failed example:
    gp('intnum(x=0, 1, x^(-1/2))')
Expected:
    1.999999999999999999999999999998...
Got:
    1.999999999999999999990291881
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 99, in sage.tests.french_book.integration_doctest
Failed example:
    gp('intnum(x=[0, -1/2], 1, x^(-1/2))')
Expected:
    2.00000000000000000000000000000...
Got:
    2.000000000000000000000000000
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 104, in sage.tests.french_book.integration_doctest
Failed example:
    gp('intnum(x=[0, -1/42], 1, x^(-1/2))')
Expected:
    1.9999999999999999999999999999996...
Got:
    1.999999999999999999996899473
**********************************************************************

jdemeyer · 2013-09-03T12:22:45Z

comment:11

On Linux ia64:

sage -t --long devel/sage/sage/tests/french_book/integration_doctest.py
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 30, in sage.tests.french_book.integration_doctest
Failed example:
    N(integrate(exp(-x^2)*log(x), x, 17, 42))
Expected:
    2.5657285006962035e-127
Got:
    2.565728500696221e-127
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 42, in sage.tests.french_book.integration_doctest
Failed example:
    numerical_integral(exp(-x^2)*log(x), 17, 42)
Expected:
    (2.5657285006962035e-127, 3.3540254049238093e-128)
Got:
    (2.565728500696221e-127, 3.3540254049023813e-128)
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 59, in sage.tests.french_book.integration_doctest
Failed example:
    N(integrate(exp(-x^2)*log(x), x, 17, 42), 200)
Expected:
    2.5657285006962035e-127
Got:
    2.565728500696221e-127
**********************************************************************

zimmermann6 · 2013-09-03T13:03:49Z

comment:12

the new attachment should fix the numerical noise issues on both 32-bit systems and ia64.
I'm not sure the notation 1.2345... works with the scientific notation, thus I've
used # rel tol in some places.

Paul

jdemeyer · 2013-09-06T08:15:51Z

comment:13

Replying to @zimmermann6:

the new attachment should fix the numerical noise issues on both 32-bit systems and ia64.
I'm not sure the notation 1.2345... works with the scientific notation, thus I've
used # rel tol in some places.

The ... notation in doctest results works purely with strings, it doesn't interpret the numbers. Tolerances like # rel tol do interpret the numbers, so that's probably the better choice indeed.

fchapoton · 2013-09-22T11:17:42Z

comment:14

Hello,

I am not happy with the indentation: it should be 4 spaces instead of 2 !

Otherwise, this should be good to go.

zimmermann6 · 2013-11-13T10:00:27Z

comment:15

Attachment: trac_14318_doctests_from_french_book.patch.gz

I am not happy with the indentation: it should be 4 spaces instead of 2 !

fixed in the new attachment.

Paul

jdemeyer · 2013-11-22T14:44:55Z

comment:16

There still remains

sage -t --long devel/sage/sage/tests/french_book/integration_doctest.py
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 94, in sage.tests.french_book.integration_doctest
Failed example:
    gp('intnum(x=0, 1, x^(-1/2))')
Expected:
    1.999999999999999999999...
Got:
    1.999999999999999999990291881
**********************************************************************
File "devel/sage/sage/tests/french_book/integration_doctest.py", line 104, in sage.tests.french_book.integration_doctest
Failed example:
    gp('intnum(x=[0, -1/42], 1, x^(-1/2))')
Expected:
    1.999999999999999999999...
Got:
    1.999999999999999999996899473
**********************************************************************

fchapoton · 2013-12-22T19:40:10Z

Commit: 91f4bcb

fchapoton · 2013-12-22T19:40:10Z

New commits:

`91f4bcb`	`trac #14318 lower precision required`
`804f8f9`	`#14318: More doctests from the book "Calcul mathématique avec Sage" chapter "integration"`

fchapoton · 2013-12-22T19:40:10Z

Branch: u/chapoton/14318

fchapoton · 2014-01-05T09:56:57Z

comment:18

Paul or Laurent, if you agree with my changes, you can set this to positive review.

zimmermann6 · 2014-01-06T21:59:37Z

comment:19

Paul or Laurent, if you agree with my changes, you can set this to positive review.

Frédéric, commit 91f4bcb is fine to me. I guess the other one (804f8f9) is just the original file?

Paul

fchapoton · 2014-01-07T08:39:57Z

comment:20

Yes, the first commit is just the patch trac_14318_doctests_from_french_book.patch turned into a git commit

zimmermann6 · 2014-01-07T08:49:56Z

Changed author from Laurent Fousse, Paul Zimmermann to Laurent Fousse, Paul Zimmermann, Frédéric Chapoton

zimmermann6 · 2014-01-07T08:49:56Z

Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Paul Zimmermann

zimmermann6 · 2014-01-07T08:49:56Z

comment:21

thanks, then I give a positive review.

Paul

sagetrac-lfousse mannequin added this to the sage-5.11 milestone Mar 20, 2013

sagetrac-lfousse mannequin added t: tests labels Mar 20, 2013

sagetrac-lfousse mannequin assigned sagetrac-mvngu Mar 20, 2013

sagetrac-lfousse mannequin added the s: needs review label Mar 25, 2013

jdemeyer added s: needs work and removed s: needs review labels Apr 9, 2013

jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013

This comment has been minimized.

Sign in to view

zimmermann6 added s: needs review and removed s: needs work labels Aug 23, 2013

fchapoton added s: positive review and removed s: needs review labels Aug 30, 2013

fchapoton changed the title ~~More doctests from the book "Calcul mathématique avec Sage"~~ More doctests from the book "Calcul mathématique avec Sage" chapter "integration" Aug 30, 2013

This comment has been minimized.

Sign in to view

jdemeyer added s: needs work and removed s: positive review labels Sep 2, 2013

zimmermann6 removed the s: needs work label Sep 3, 2013

zimmermann6 added the s: needs review label Sep 3, 2013

fchapoton added s: needs work and removed s: needs review labels Sep 22, 2013

zimmermann6 added s: needs review and removed s: needs work labels Nov 13, 2013

jdemeyer added s: needs work and removed s: needs review labels Nov 22, 2013

fchapoton added s: needs review and removed s: needs work labels Dec 22, 2013

zimmermann6 added s: positive review and removed s: needs review labels Jan 7, 2014

vbraun removed the s: positive review label Jan 16, 2014

vbraun closed this as completed in ebfa56f Jan 16, 2014

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

More doctests from the book "Calcul mathématique avec Sage" chapter "integration" #14318

More doctests from the book "Calcul mathématique avec Sage" chapter "integration" #14318

sagetrac-lfousse mannequin commented Mar 20, 2013

sagetrac-lfousse mannequin commented Mar 20, 2013

jdemeyer commented Apr 9, 2013

zimmermann6 commented Aug 23, 2013

zimmermann6 commented Aug 23, 2013

This comment has been minimized.

fchapoton commented Aug 30, 2013

fchapoton commented Aug 30, 2013

This comment has been minimized.

zimmermann6 commented Aug 31, 2013

jdemeyer commented Sep 2, 2013

jdemeyer commented Sep 3, 2013

zimmermann6 commented Sep 3, 2013

jdemeyer commented Sep 6, 2013

fchapoton commented Sep 22, 2013

zimmermann6 commented Nov 13, 2013

jdemeyer commented Nov 22, 2013

fchapoton commented Dec 22, 2013

fchapoton commented Dec 22, 2013

fchapoton commented Dec 22, 2013

fchapoton commented Jan 5, 2014

zimmermann6 commented Jan 6, 2014

fchapoton commented Jan 7, 2014

zimmermann6 commented Jan 7, 2014

zimmermann6 commented Jan 7, 2014

zimmermann6 commented Jan 7, 2014

More doctests from the book "Calcul mathématique avec Sage" chapter "integration" #14318

More doctests from the book "Calcul mathématique avec Sage" chapter "integration" #14318

Comments

sagetrac-lfousse mannequin commented Mar 20, 2013

sagetrac-lfousse mannequin commented Mar 20, 2013

jdemeyer commented Apr 9, 2013

zimmermann6 commented Aug 23, 2013

zimmermann6 commented Aug 23, 2013

This comment has been minimized.

fchapoton commented Aug 30, 2013

fchapoton commented Aug 30, 2013

This comment has been minimized.

zimmermann6 commented Aug 31, 2013

jdemeyer commented Sep 2, 2013

jdemeyer commented Sep 3, 2013

zimmermann6 commented Sep 3, 2013

jdemeyer commented Sep 6, 2013

fchapoton commented Sep 22, 2013

zimmermann6 commented Nov 13, 2013

jdemeyer commented Nov 22, 2013

fchapoton commented Dec 22, 2013

fchapoton commented Dec 22, 2013

fchapoton commented Dec 22, 2013

fchapoton commented Jan 5, 2014

zimmermann6 commented Jan 6, 2014

fchapoton commented Jan 7, 2014

zimmermann6 commented Jan 7, 2014

zimmermann6 commented Jan 7, 2014

zimmermann6 commented Jan 7, 2014