Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update M4RI to version 20130416 #14335

Closed
malb opened this issue Mar 22, 2013 · 9 comments
Closed

update M4RI to version 20130416 #14335

malb opened this issue Mar 22, 2013 · 9 comments

Comments

@malb
Copy link
Member

malb commented Mar 22, 2013

20130416 is mainly maintenance release of M4RI improving performance for small matrices.

Release notes are here: https://bitbucket.org/malb/m4ri/wiki/M4RI-20130416

Install http://boxen.math.washington.edu/home/malb/spkgs/libm4ri-20130416.spkg

Component: packages: standard

Author: Martin Albrecht

Reviewer: Volker Braun

Merged: sage-5.10.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14335

@malb malb added this to the sage-5.9 milestone Mar 22, 2013
@malb

This comment has been minimized.

@malb
Copy link
Member Author

malb commented Mar 22, 2013

comment:2

FWIW, I just built Sage 5.8 from scratch with the SPKG linked above on bsd.math.washington.edu.

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Mar 23, 2013

comment:3

I successfully compiled the spkg with sage 5.8 on my arm box.

@SnarkBoojum
Copy link
Mannequin

SnarkBoojum mannequin commented Mar 23, 2013

comment:4

I looked at libm4rie's compilation and found there where many warnings ; I checked libm4ri's build log, and found that many, many files trigger the following warnings:

In file included from ./m4ri/mzd.h:45:0,
                 from m4ri/brilliantrussian.h:41,
                 from m4ri/brilliantrussian.c:28:
./m4ri/misc.h:577:0: warning: "__M4RI_CPU_L3_CACHE" redefined [enabled by default]
In file included from ./m4ri/mzd.h:35:0,
                 from m4ri/brilliantrussian.h:41,
                 from m4ri/brilliantrussian.c:28:
./m4ri/m4ri_config.h:11:0: note: this is the location of the previous definition
In file included from ./m4ri/mzd.h:45:0,
                 from m4ri/brilliantrussian.h:41,
                 from m4ri/brilliantrussian.c:28:
./m4ri/misc.h:586:0: warning: "__M4RI_CPU_L2_CACHE" redefined [enabled by default]
In file included from ./m4ri/mzd.h:35:0,
                 from m4ri/brilliantrussian.h:41,
                 from m4ri/brilliantrussian.c:28:
./m4ri/m4ri_config.h:10:0: note: this is the location of the previous definitionIn file included from ./m4ri/mzd.h:45:0,
                 from m4ri/brilliantrussian.h:41,
                 from m4ri/brilliantrussian.c:28:
./m4ri/misc.h:595:0: warning: "__M4RI_CPU_L1_CACHE" redefined [enabled by default]
In file included from ./m4ri/mzd.h:35:0,
                 from m4ri/brilliantrussian.h:41,
                 from m4ri/brilliantrussian.c:28:
./m4ri/m4ri_config.h:9:0: note: this is the location of the previous definition

It doesn't harm but obfuscates the logs and perhaps means there's some header file missing guards.

@malb
Copy link
Member Author

malb commented Mar 24, 2013

comment:5

Those warnings are expected. It means that L1-L3 were not detected successfully and are replaced by default values. So it's not critical. It might make sense to investigate how to detect L1/L2 on your kind of boxes (for future releases) and we should also print a less scary warning once.

@vbraun
Copy link
Member

vbraun commented Apr 18, 2013

Author: Martin Albrecht

@vbraun
Copy link
Member

vbraun commented Apr 18, 2013

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Apr 18, 2013

comment:6

Looks good to me.

@jdemeyer
Copy link

Merged: sage-5.10.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants