Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doctest directory to the reference manual #14376

Closed
jdemeyer opened this issue Mar 28, 2013 · 10 comments
Closed

Add doctest directory to the reference manual #14376

jdemeyer opened this issue Mar 28, 2013 · 10 comments

Comments

@jdemeyer
Copy link

Depends on #14370

CC: @jhpalmieri @roed314

Component: documentation

Author: John Palmieri

Reviewer: Jeroen Demeyer

Merged: sage-5.9.beta3

Issue created by migration from https://trac.sagemath.org/ticket/14376

@jhpalmieri
Copy link
Member

comment:1

Here's an initial patch.

@jhpalmieri
Copy link
Member

Author: John Palmieri

@jhpalmieri
Copy link
Member

Dependencies: #14370

@jdemeyer
Copy link
Author

comment:3

Attachment: trac_14376.patch.gz

Your patch actually breaks doctesting sage/doctest/forker.py because of line number changes.

@jdemeyer
Copy link
Author

Reviewer: Jeroen Demeyer

@jhpalmieri
Copy link
Member

comment:4

The patch from 16 hours ago failed doctesting, but the one from 11 hours ago fixed those line numbers, at least for me. Can you make sure you used the right patch?

@jdemeyer
Copy link
Author

comment:5

Replying to @jhpalmieri:

Can you make sure you used the right patch?

I guess I didn't, but the ticket was at "needs review" when I tried it :-)

@jhpalmieri
Copy link
Member

comment:6

Replying to @jdemeyer:

Replying to @jhpalmieri:

Can you make sure you used the right patch?

I guess I didn't, but the ticket was at "needs review" when I tried it :-)

I know, sorry, but then I found the doctest errors and fixed them without saying anything, only posting a new patch.

@jdemeyer
Copy link
Author

jdemeyer commented Apr 1, 2013

Merged: sage-5.9.beta3

@jdemeyer
Copy link
Author

jdemeyer commented Apr 1, 2013

comment:7

Looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants