Clean SAGE_ROOT from module_list.py (again)

[kiwifb]

A few tickets have been using SAGE_ROOT directly or not used SAGE_INC since my last clean up. After cleaning direct calls to SAGE_ROOT in the rest of sage we need to spend some time here.

The use of SAGE_INC has also been normalized everywhere so it is not necessary to add a final "/". The use of predefined depend variables has been enforced as much as I could see it.

Apply to the sage library:

• attachment: trac14393-cleanup.patch

CC: @ohanar @cschwan

Component: build

Author: François Bissey

Reviewer: Christopher Schwan

Merged: sage-5.9.beta5

Issue created by migration from https://trac.sagemath.org/ticket/14393

[kiwifb]

comment:1

It has been bothering me for a while that a few people have been using naked SAGE_ROOT in there.

[kiwifb]

comment:2

Could you have a look at this Christopher? I was hoping Andrew would be interested but he must be busy elsewhere. I'd very much want to see this in 5.9.

[cschwan]

comment:3

Looks good to me. Do you want me to test it as well? I could do this at the weekend.

[kiwifb]

comment:4

It should be done properly, so yes testing. Testing is the only way to see if I missed something, which I don't think I did.

[cschwan]

comment:5

OK, I will test it this weekend.

[cschwan]

comment:6

I checked with beta2; patch applies cleanly and the build is fine.

[kiwifb]

Reviewer: Christopher Schwan

[kiwifb]

comment:7

OK I put it in positive review then.

[kiwifb]

Author: Francois Bissey

[jdemeyer]

Attachment: trac14393-cleanup.patch.gz

clean up module_list.py

[jdemeyer]

Changed author from Francois Bissey to François Bissey

[jdemeyer]

Merged: sage-5.9.beta5

[nexttime]

comment:10

Replying to @kiwifb:

It should be done properly, so yes testing. Testing is the only way to see if I missed something, which I don't think I did.

You only missed one instance (#14531), for an optional spkg.