Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Quiver mutation types for Gale-Robinson Quivers and other Period quivers #14444

Open
sagetrac-gmoose05 mannequin opened this issue Apr 11, 2013 · 37 comments
Open

Implement Quiver mutation types for Gale-Robinson Quivers and other Period quivers #14444

sagetrac-gmoose05 mannequin opened this issue Apr 11, 2013 · 37 comments
Assignees
@sagetrac-sage-combinat
Labels
c: combinatorics p: major / 3 s: needs work t: enhancement
Milestone
sage-6.10

Comments

@sagetrac-gmoose05
Copy link
Mannequin

sagetrac-gmoose05 mannequin commented Apr 11, 2013

See Fordy and Marsh's paper http://arxiv.org/abs/0904.0200, in particular Example 8.7.

Apply:

CC: @stumpc5

Component: combinatorics

Keywords: quiver

Author: Gregg Musiker

Branch/Commit: u/chapoton/14444 @ cc6b97f

Issue created by migration from https://trac.sagemath.org/ticket/14444
@sagetrac-gmoose05 sagetrac-gmoose05 mannequin added this to the sage-5.11 milestone Apr 11, 2013
@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented May 22, 2013

comment:1

First draft of this patch. Still needs to be better documented and streamlined. For instance, currently, creating primitive period 1 quivers by going through matrices instead of directly through digraph. But, the examples appear to work. Although sign convention should be double-checked.

Should other types such as quivers associated to other Brane Tilings, like dP3, F0, etc. also be hard-coded?

An update to this patch will come in the next few days, but should be working for now.

Gregg

@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented May 23, 2013

Attachment: trac_14444-Period-Quivers.patch.gz

@sagetrac-gmoose05

This comment has been minimized.

Sign in to view
@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented May 23, 2013

comment:2

Attachment: trac_14444-period-quivers-gm.patch.gz

This patch has now been updated and works directly with digraphs as opposed to matrices.

It also automatically re-interprets the primitive period 1 quivers as the associated affine A quivers.

A future ticket or patch will possible include general period 1 quivers or other quivers from Brane Tilings.

Should be ready for review now.

Gregg

@fchapoton
Copy link
Contributor

comment:3

It was not necessary to replace the duplicate/unused patch by an empty patch. You can give instructions for the bot in comments, as follows:

apply trac_14444-Period-Quivers.patch

then the bot will only apply this patch.

One remark:

For links to arxiv, you should use the arxiv role, like for example :arxiv:`0904.0200`

@fchapoton

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@fchapoton
Copy link
Contributor

comment:5

here is a first review patch

@fchapoton

This comment has been minimized.

Sign in to view
@fchapoton
Copy link
Contributor

Author: Gregg Musiker

@fchapoton
Copy link
Contributor

Changed keywords from quivers to quiver

@fchapoton
Copy link
Contributor

Attachment: trac_14444_review1.patch.gz

@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented Sep 20, 2013

comment:9

Examples need to be slightly updated so that Period 1 Primitives recongized as Affine A when QuiverMutationType(['P1',n,k]) is called.

Also, would be good for interface to input classes for other period 1 quivers in this patch rather than a future patch.

@fchapoton
Copy link
Contributor

Commit: da7a700

@fchapoton
Copy link
Contributor

comment:10

I have made a git branch.

New commits:

741ecfbAdded primitive period 1 quivers and Gale-Robinson quivers
da7a700trac #14444 review patch, minor details

@fchapoton
Copy link
Contributor

Branch: u/chapoton/14444

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 9, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

da36f73Merge branch 'u/chapoton/14444' of ssh://trac.sagemath.org:22/sage into 14444
59d3bd6trac #14444 cosmetic clean-up

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 9, 2014

Changed commit from da7a700 to 59d3bd6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 11, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

680184fMerge branch 'u/chapoton/14444' of ssh://trac.sagemath.org:22/sage into 14444
d1dc38ftrac #14444 repairing the broken doctests (sorry)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 11, 2014

Changed commit from 59d3bd6 to d1dc38f

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

b71954bMerge branch 'u/chapoton/14444' into 6.4.rc1
6c2ff95trac #14444 minor corrections

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 9, 2014

Changed commit from d1dc38f to 6c2ff95

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 28, 2014

Changed commit from 6c2ff95 to 7a6e222

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 28, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

7a6e222Merge branch 'u/chapoton/14444' of ssh://trac.sagemath.org:22/sage into 6.5.b4

@fchapoton
Copy link
Contributor

comment:18

Gregg, would you agree to try to get that into sage, keeping further changes for another ticket ?

@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented Jan 27, 2015

comment:19

Replying to @fchapoton:

Gregg, would you agree to try to get that into sage, keeping further changes for another ticket ?

Frederic, I am still interested in getting this into sage. I have a SAGE research assistant this semester who should have time to do this if I don't have a chance to get to this first. What did you mean exactly by "further changes"? Are you recommending I open a new ticket regarding implementing these quivers?

@fchapoton
Copy link
Contributor

comment:20

Well, there is already something about Gale-Robinson here.

And I have also made (somewhat abusing the ticket's goal) a lot of disturbing typographical/cleanup changes in the rest of the code. It would be better to get rid of that by quick inclusion in sage, so that one can start again and have cleaner tickets.
Anyway, there is a risk of conflict with the other ticket about cluster for triangulated surfaces.

@sagetrac-gmoose05
Copy link
Mannequin Author

sagetrac-gmoose05 mannequin commented Jan 28, 2015

comment:21

I think if we want to fast track this into sage, it should be updated (if needed) to make sure that a single primitive period 1 quiver is not a new quiver mutation class but is recgonized as an affine type A quiver (or multiple copies of one). Potentially only the doctests need to be updated.

If I had more time, I would develop new quiver mutation classes for more complicated period 1 quives by adding/subtracting primitive period 1 quivers appropriately. The Gale-Robinson case is essentially the case of this with two such period 1 primitives (plus the necessary fudge factor). Or by allowing the user to input a palindromic integer vector and build the rest of the period 1 quiver from the first row of the exchange matrix.

As far as you know, do these two patches still work in the current sage? If so, we can change this from needs work to needs review.

I could open up a separate ticket for the period 1 functionalities.

Gregg

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

5de6bd5Merge branch 'u/chapoton/14444' into 6.9.rc3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 9, 2015

Changed commit from 7a6e222 to 5de6bd5

@fchapoton fchapoton modified the milestones: sage-6.4, sage-6.10 Oct 9, 2015
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2015

Changed commit from 5de6bd5 to c364003

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 12, 2015

Branch pushed to git repo; I updated commit sha1. New commits:

c364003Merge branch 'u/chapoton/14444' into 6.10.b4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2016

Changed commit from c364003 to d89f4a4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 10, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

d89f4a4Merge branch 'u/chapoton/14444' into 7.3.b3

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 31, 2016

Changed commit from d89f4a4 to 18651be

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Aug 31, 2016

Branch pushed to git repo; I updated commit sha1. New commits:

18651beMerge branch 'u/chapoton/14444' in 7.4.b2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 8, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

cc6b97fMerge branch 'u/chapoton/14444' in 8.0.b9

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jun 8, 2017

Changed commit from 18651be to cc6b97f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sagetrac-sage-combinat sagetrac-sage-combinat

Labels
c: combinatorics p: major / 3 s: needs work t: enhancement
Projects
None yet
Milestone
sage-6.10
Development

No branches or pull requests
2 participants
@jdemeyer @fchapoton