Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libGAP error handling bug #14453

Closed
jdemeyer opened this issue Apr 15, 2013 · 18 comments
Closed

libGAP error handling bug #14453

jdemeyer opened this issue Apr 15, 2013 · 18 comments

Comments

@jdemeyer
Copy link

The libGAP error handler (error_handler()) in sage/libs/gap/util.pyx should use set_sage_signal_handler_message() instead of sig_str(). Unfortunately, this exposes a bug in GCC-4.8.0: #14460 (work-around: compile with -fno-tree-dominator-opts).

CC: @vbraun

Component: interfaces

Author: Jeroen Demeyer

Reviewer: Volker Braun

Merged: sage-5.10.beta0

Issue created by migration from https://trac.sagemath.org/ticket/14453

@jdemeyer
Copy link
Author

comment:1

Attachment: sage_crash_ihsJs4.log

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

comment:3

Looks like a GCC compiler bug (GCC-4.8.0).

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Apr 16, 2013

comment:7

Thanks for debugging this! Should we still treat this as critical or maybe just wait until gcc-4.8.1 is out?

@jdemeyer
Copy link
Author

comment:8

Independently of the GCC issue, there still is a segmentation fault with Cython-0.19b2. Perhaps we should also fix that here.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

comment:10

The Cython segfault also looks like an upstream (Cython-0.19b2) problem. So libGAP does a good job of testing various upstream projects :-)

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer
Copy link
Author

comment:11

Modulo upstream issues, this patch should be fine and can be applied.

@jdemeyer
Copy link
Author

comment:12

Attachment: 14453_libgap.patch.gz

The critical bug is #14460.

@vbraun
Copy link
Member

vbraun commented Apr 16, 2013

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Apr 16, 2013

comment:13

Looks good to me.

@jdemeyer
Copy link
Author

Merged: sage-5.10.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants