Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to --optional doctests #14495

Closed
jdemeyer opened this issue Apr 26, 2013 · 9 comments
Closed

Improvement to --optional doctests #14495

jdemeyer opened this issue Apr 26, 2013 · 9 comments

Comments

@jdemeyer
Copy link

  1. Clearly document and test that --optional tags and options are case-insensitive.
  2. --show-skipped never mentions skipped sage tests.
  3. Check for invalid --optional arguments (basically, anything that isn't alphanumeric).

CC: @simon-king-jena

Component: doctest framework

Author: Jeroen Demeyer

Reviewer: Volker Braun

Merged: sage-5.9.rc1

Issue created by migration from https://trac.sagemath.org/ticket/14495

@jdemeyer

This comment has been minimized.

@jhpalmieri
Copy link
Member

comment:2

In the developer's guide, in conventions.rst, it says

      Any words after ``# optional`` are
      interpreted as a list of package names, separated by spaces.
      Any punctuation (periods, commas, hyphens, semicolons, ...)
      after the first word ends the list of packages.
      Hyphens or colons between the word ``optional`` and the first
      package name are allowed.
      Also, all text is converted to lower case.

So the case-insensitivity is mentioned, but could be emphasized more.

@jdemeyer
Copy link
Author

comment:3

Please review.

@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer
Copy link
Author

Attachment: 14495_optional_doctests.patch.gz

@jdemeyer
Copy link
Author

comment:4

Given that I would prefer to merge this in sage-5.9.rc1, I appreciate a quick review :-)

@vbraun
Copy link
Member

vbraun commented Apr 28, 2013

comment:5

Looks good to me

@vbraun
Copy link
Member

vbraun commented Apr 28, 2013

Reviewer: Volker Braun

@jdemeyer
Copy link
Author

Merged: sage-5.9.rc1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants