Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in the reference manual: GAP interface and Weyl group #14503

Closed
mathzeta opened this issue Apr 28, 2013 · 10 comments
Closed

Typos in the reference manual: GAP interface and Weyl group #14503

mathzeta opened this issue Apr 28, 2013 · 10 comments

Comments

@mathzeta
Copy link

Following https://groups.google.com/forum/?fromgroups=#!topic/sage-devel/zijERXXw43M, here are two small and trivial fixes for the reference manual:

  • GAP interface misses the G in GAP.
  • Weyl group category links to a Wikipedia article that does not exist

Apply:

Component: documentation

Author: Tomer Bauer

Reviewer: Nathann Cohen

Merged: sage-5.10.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14503

@mathzeta
Copy link
Author

Attachment: trac_14503_typos.patch.gz

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 29, 2013

comment:1

Makes sense, and it is not likely to do anything very bad :-D

This being said, could you replace the line containing the link with the following ?

See the `Wikipedia page of Weyl Groups <Weyl_group>`.

That's how we now refer to Wikipedia pages :-)

Thanks !

Nathann

@nathanncohen nathanncohen mannequin added the s: needs review label Apr 29, 2013
@mathzeta
Copy link
Author

comment:3

Attachment: trac_14503_typos_wikipedia.patch.gz

Replying to @nathanncohen:

This being said, could you replace the line containing the link with the following ?

See the `Wikipedia page of Weyl Groups <Weyl_group>`.

That's how we now refer to Wikipedia pages :-)

Attached is an extra patch with proper Wikipedia links. In the process of learning Sage's ReST rules, I stumbled upon another broken Wikipedia link: multicommodity flow. I hope that piggybacking this ticket is OK.

@nathanncohen

This comment has been minimized.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 29, 2013

comment:4

Helloooooooooooooo !!

Attached is an extra patch with proper Wikipedia links. In the process of learning Sage's ReST rules, I stumbled upon another broken Wikipedia link: multicommodity flow. I hope that piggybacking this ticket is OK.

Gloops. The one from generic_graph.py is probably one of my mistakes :-)

Thank you for those patches ! There is no problem at all with having several patches on the same ticket. You just need to explicitly say in the ticket's description how they are to be applied in that case (just one, or the other, or both). I just did it, so that you can see how you can create links toward patches in a ticket :-)

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 29, 2013

comment:5

Good to go !

Nathann

@jdemeyer
Copy link

comment:6

Please fill in your real names as Author and Reviewer.

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Apr 30, 2013

Reviewer: Nathann Cohen

@mathzeta
Copy link
Author

Author: Tomer Bauer

@jdemeyer
Copy link

jdemeyer commented May 7, 2013

Merged: sage-5.10.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants