Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Composition of morphisms #14537

Closed
sagetrac-tfeulner mannequin opened this issue May 6, 2013 · 9 comments
Closed

Composition of morphisms #14537

sagetrac-tfeulner mannequin opened this issue May 6, 2013 · 9 comments

Comments

@sagetrac-tfeulner
Copy link
Mannequin

sagetrac-tfeulner mannequin commented May 6, 2013

The following code leads to a TypeError:

sage: F.<a> = GF(4)
sage: f = F.Hom(F).identity()
sage: g = F.hom([a])
sage: h = (g*f)
sage: f*h
...
TypeError: right (=Composite map:
  From: Finite Field in a of size 2^2
  To:   Finite Field in a of size 2^2
  Defn:   Identity endomorphism of Finite Field in a of size 2^2
        then
          Ring endomorphism of Finite Field in a of size 2^2
          Defn: a |--> a) must be a morphism to multiply it by Identity endomorphism of Finite Field in a of size 2^2

The problem is solved by relaxing the type checking in the multiplication procedure to accept Maps and not only Morphisms

CC: @simon-king-jena

Component: categories

Keywords: composition, morphisms, sd48

Author: Thomas Feulner

Reviewer: Volker Braun

Merged: sage-5.11.beta3

Issue created by migration from https://trac.sagemath.org/ticket/14537

@sagetrac-tfeulner sagetrac-tfeulner mannequin added this to the sage-5.11 milestone May 6, 2013
@sagetrac-tfeulner
Copy link
Mannequin Author

sagetrac-tfeulner mannequin commented May 6, 2013

Attachment: trac_14537_identity_morphism.patch.gz

@sagetrac-tfeulner

This comment has been minimized.

@vbraun
Copy link
Member

vbraun commented Jun 20, 2013

comment:2

Looks good to me

@vbraun
Copy link
Member

vbraun commented Jun 20, 2013

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Jun 20, 2013

Author: Thomas Feulner

@vbraun
Copy link
Member

vbraun commented Jun 20, 2013

Changed keywords from composition, morphisms to composition, morphisms, sd48

@nthiery

This comment has been minimized.

@nthiery

This comment has been minimized.

@jdemeyer
Copy link

Merged: sage-5.11.beta3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants