Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in combinat.py #14554

Closed
sagetrac-scmancuso mannequin opened this issue May 8, 2013 · 6 comments
Closed

Fix typo in combinat.py #14554

sagetrac-scmancuso mannequin opened this issue May 8, 2013 · 6 comments

Comments

@sagetrac-scmancuso
Copy link
Mannequin

sagetrac-scmancuso mannequin commented May 8, 2013

The string representation for FilteredCombinatorialClass gives the description as "Filtered sublass of " instead of "Filtered subclass of " (note the missing 'c' in the first). This is a simple correction of this typo and all places where it occurs in doctests.

Component: combinatorics

Author: Scott Mancuso

Reviewer: Nicolas M. Thiéry

Merged: sage-5.10.beta3

Issue created by migration from https://trac.sagemath.org/ticket/14554

@sagetrac-scmancuso
Copy link
Mannequin Author

sagetrac-scmancuso mannequin commented May 8, 2013

Attachment: trac_14554_combinat_typo.patch.gz

@nthiery
Copy link
Contributor

nthiery commented May 8, 2013

Reviewer: Nicolas M. Thiéry

@nthiery
Copy link
Contributor

nthiery commented May 8, 2013

comment:3

Sounds good. You can set a positive review on my behalf as soon as the patchbot light goes green!

Thanks for this first contribution!

By the way, don't worry too much for *CombinatorialClass: those are
meant to disappear at some point.

Cheers,
Nicolas

@kcrisman
Copy link
Member

kcrisman commented May 9, 2013

comment:4

Patchbot isn't working right, but it's doable by hand.

Doctesting 1 file.
sage -t sage/combinat/combinat.py
    [397 tests, 15.17 s]
----------------------------------------------------------------------
All tests passed!
----------------------------------------------------------------------
Total time for all tests: 15.3 seconds
    cpu time: 2.4 seconds
    cumulative wall time: 15.2 seconds

Running full tests now but I don't think there will be a problem, Nicolas.

@kcrisman
Copy link
Member

kcrisman commented May 9, 2013

comment:5

All is well.

@jdemeyer
Copy link

Merged: sage-5.10.beta3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants