cleanup of doc in sha_tate.py

[fchapoton]

just a small patch to clean minor things in this file on tate-shafarevich

• one unused variable found by pyflakes
• minor details in the documentation
• raise converted into python3 syntax

Depends on #14571

Component: elliptic curves

Keywords: tate shafarevich

Author: Frédéric Chapoton

Reviewer: Volker Braun

Merged: sage-5.10.rc1

Issue created by migration from https://trac.sagemath.org/ticket/14561

[fchapoton]

Attachment: trac_14561_cleanup_of_sha-fc.patch.gz

[vbraun]

comment:2

You are duplicating the citation:

[plane_cur] /home/vbraun/opt/sage-5.10.beta2/local/lib/python2.7/site-packages/sage/schemes/elliptic_curves/sha_tate.py:docstring of sage.schemes.elliptic_curves.sha_tate.Sha.an_padic:8: WARNING: duplicate citation MTT, other instance in /home/vbraun/opt/sage-5.10.beta2/devel/sage/doc/en/reference/plane_curves/../plane_curves/sage/schemes/elliptic_curves/sha_tate.rst

[fchapoton]

comment:3

I do not have this problem on 5.10.beta1.

The reference is not duplicated in the file itself.

I will try with beta2 when I got it.

[fchapoton]

comment:4

no problem either with 5.10.beta2. The doc builds without any warnings.

[vbraun]

Reviewer: Volker Braun

[vbraun]

Author: Frederic Chapoton

[vbraun]

comment:5

Sorry for the confusion, stale citation pickle I think...

[fchapoton]

comment:6

Well, thanks for the review !

[jdemeyer]

Dependencies: #14571

[fchapoton]

comment:8

Maybe I should rather remove the offending Unicode sha ?

[vbraun]

comment:9

No, its a good testcase. Eventually we should just extend the pdf doc build by all unicode code points that we need, and the patch at #14571 is a step in that direction.

[jdemeyer]

Merged: sage-5.10.rc1

[jdemeyer]

Changed author from Frederic Chapoton to Frédéric Chapoton