Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ship auto-generated files in the Sage library sources #14739

Closed
jdemeyer opened this issue Jun 14, 2013 · 10 comments
Closed

Do not ship auto-generated files in the Sage library sources #14739

jdemeyer opened this issue Jun 14, 2013 · 10 comments

Comments

@jdemeyer
Copy link

Even after #14700, there are still various auto-generated files which are shipped:

sage/libs/pari/gen.h
sage/modular/arithgroup/farey_symbol.h
sage/rings/real_mpfi.h
sage/symbolic/pynac.h

and lots of .rst files like

doc/en/reference/algebras/sage/algebras/free_algebra.rst

Component: distribution

Author: John Palmieri

Reviewer: Jeroen Demeyer

Merged: sage-5.11.beta2

Issue created by migration from https://trac.sagemath.org/ticket/14739

@jdemeyer jdemeyer added this to the sage-5.11 milestone Jun 14, 2013
@tscrim
Copy link
Collaborator

tscrim commented Jun 16, 2013

comment:1

Shouldn't the .rst files be included in the (compiled) distribution since they are the output for documentation and we don't want to make a user (re)build the documentation as a part of the installation?

@jhpalmieri
Copy link
Member

Attachment: trac_14739-manifest.patch.gz

@jhpalmieri
Copy link
Member

Author: John Palmieri

@jhpalmieri
Copy link
Member

comment:2

Here's a patch. By the way, sage --sdist ... on OS X does not preserve the symlinks to conf.py in the subdirectories of doc/en/reference: it creates copies of the file instead of links. is that a bug in our code, or is it something in Python?

@jdemeyer
Copy link
Author

Reviewer: Jeroen Demeyer

@jdemeyer jdemeyer changed the title Do not ship auto-generated files in the Sage library Do not ship auto-generated files in the Sage library sources Jun 18, 2013
@jdemeyer
Copy link
Author

comment:4

Replying to @tscrim:

Shouldn't the .rst files be included in the (compiled) distribution since they are the output for documentation and we don't want to make a user (re)build the documentation as a part of the installation?

This is about source distributions.

@jdemeyer
Copy link
Author

comment:5

Replying to @jhpalmieri:

Is that a bug in our code, or is it something in Python?

I'm not sure, it might be because of distutils.

@tscrim
Copy link
Collaborator

tscrim commented Jun 18, 2013

comment:6

Replying to @jdemeyer:

This is about source distributions.

Ah okay, thanks.

@nexttime
Copy link
Mannequin

nexttime mannequin commented Jun 18, 2013

comment:7

Replying to @tscrim:

Shouldn't the .rst files be included in the (compiled) distribution since they are the output for documentation and we don't want to make a user (re)build the documentation as a part of the installation?

It would be nice to have a separate tarball with (only) the pre-built documentation though, but that's another thing.

@jdemeyer
Copy link
Author

Merged: sage-5.11.beta2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants