Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lattice of flats to Matroid class #14786

Closed
sagetrac-ahmorales mannequin opened this issue Jun 20, 2013 · 12 comments
Closed

Add lattice of flats to Matroid class #14786

sagetrac-ahmorales mannequin opened this issue Jun 20, 2013 · 12 comments
Assignees
@Stefan
Labels
c: matroid theory p: minor / 4 t: enhancement
Milestone
sage-6.5

Comments

@sagetrac-ahmorales
Copy link
Mannequin

sagetrac-ahmorales mannequin commented Jun 20, 2013

The new Matroid class has functions for flats but there is not implementation of the lattice of flats.

Depends on #7477

CC: @sagetrac-Stefan @sagetrac-yomcat

Component: matroid theory

Keywords: lattice, flat, days49

Author: Frédéric Chapoton

Branch/Commit: 6a03702

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/14786
@sagetrac-ahmorales sagetrac-ahmorales mannequin added this to the sage-5.11 milestone Jun 20, 2013
@sagetrac-Stefan
Copy link
Mannequin

sagetrac-Stefan mannequin commented Jun 20, 2013

comment:2

A quick implementation was created here:

https://groups.google.com/d/msg/sage-matroid/nfyaO7f2_w0/GBg0aeppinkJ

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-yomcat sagetrac-yomcat mannequin removed the c: combinatorics label Aug 26, 2013
@sagetrac-yomcat sagetrac-yomcat mannequin assigned Stefan and unassigned sagetrac-sage-combinat Aug 26, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@fchapoton
Copy link
Contributor

Changed author from ahmorales to Frédéric Chapoton

@fchapoton
Copy link
Contributor

Commit: c84dfb4

@fchapoton
Copy link
Contributor

Branch: u/chapoton/14786

@fchapoton
Copy link
Contributor

New commits:

c84dfb4trac #14786 lattice of flats of a matroid

@tscrim
Copy link
Collaborator

tscrim commented Dec 13, 2014

comment:9

Very minor point (and paranoia), but could you change the cover relation to x < y (instead of x <= y)? If you do, then you can set a positive review on my behalf, and if you think it's fine, then you can set a positive review too.

@tscrim
Copy link
Collaborator

tscrim commented Dec 13, 2014

Reviewer: Travis Scrimshaw

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 16, 2014

Branch pushed to git repo; I updated commit sha1. New commits:

91934c4Merge branch 'u/chapoton/14786' of trac.sagemath.org:sage into 6.5.b2
6a03702trac #14786 replacing <= by < in lattice of flats of matroids

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 16, 2014

Changed commit from c84dfb4 to 6a03702

@fchapoton
Copy link
Contributor

comment:11

done, and set to positive review. thanks, Travis.

@tscrim
Copy link
Collaborator

tscrim commented Jan 13, 2015

comment:12

Hopefully now it will get merged...

@tscrim tscrim modified the milestones: sage-6.4, sage-6.5 Jan 13, 2015
@vbraun
Copy link
Member

vbraun commented Jan 29, 2015

Changed branch from u/chapoton/14786 to 6a03702

@vbraun vbraun closed this as completed in 39ebc7d Jan 29, 2015
@tscrim tscrim mentioned this issue Oct 18, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stefan Stefan

Labels
c: matroid theory p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-6.5
Development

No branches or pull requests
4 participants
@vbraun @tscrim @jdemeyer @fchapoton