Declare PARI finite field functions (FF_*), wrap ffgen() and ffinit()

[pjbruin]

To access the PARI library functions related to the t_FFELT type for finite fields (see #12142), these functions need to be declared in sage/libs/pari/decl.pxi. Also, wrappers for the functions ffgen() and ffinit() are missing.

I am attaching a patch, which will become a dependency of #12142.

Apply:

• attachment: trac14818-pari_FF_decl.patch
• attachment: trac_14818-reviewer.patch

CC: @jpflori

Component: finite rings

Keywords: pari

Author: Peter Bruin

Reviewer: Jean-Pierre Flori

Merged: sage-5.12.beta0

Issue created by migration from https://trac.sagemath.org/ticket/14818

[pjbruin]

based on 5.11.beta3

[pjbruin]

comment:1

Attachment: trac14818-pari_FF_decl.patch.gz

[jpflori]

Reviewer: Jean-Pierre Flori

[jpflori]

Work Issues: doctests

[jpflori]

comment:3

Please add some doctests.

I know this will be indirectly doctested through further tickets, but it would be nice to have some example directly in the docstrings of ffgen and ffinit.

[jpflori]

comment:4

There is also a problem with the docstring for ffinit which mentions a polynomial P.

And the doc avout the v variable is kind of obscure.
In the docstring for get_var it's mentioned it should be a string or -1.
Here it seems you suggest it can be an integer.
Indeed, the PARI ffinit functions wants a long and will treat negative input in a special way, but the point of the call to get_var is to convert the var's string to the correct integer.
So either skip the get_var call or correcte the docstring.
I think the second option is better, and is what you wanted, isn't it?

[jpflori]

Changed work issues from doctests to doctests, docstring

[jpflori]

Reviewer patch.

[jpflori]

Changed work issues from doctests, docstring to none

[jpflori]

comment:6

Attachment: trav_14818-reviewer.patch.gz

Just added simple doctests and corrected the doc, so let's consider this a reviewer patch and I give positive review to the real changes made by Peter.

[pjbruin]

comment:8

Thanks, I realise that I was really sloppy with the docstrings...

[jpflori]

Reviewer patch.

[jpflori]

comment:9

Attachment: trac_14818-reviewer.patch.gz

Correct and better named patch.

[jpflori]

comment:10

For the patchbot, apply only:

• attachment: trac14818-pari_FF_decl.patch
• attachment: trac_14818-reviewer.patch

[pjbruin]

comment:11

The patchbot doesn't seem to get it:

Apply trac14818-pari_FF_decl.patch, trac_14818-reviewer.patch

[jdemeyer]

Merged: sage-5.12.beta0