Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compute the p-adic Gamma function #14880

Closed
sagetrac-asalerno mannequin opened this issue Jul 12, 2013 · 11 comments
Closed

Compute the p-adic Gamma function #14880

sagetrac-asalerno mannequin opened this issue Jul 12, 2013 · 11 comments

Comments

@sagetrac-asalerno
Copy link
Mannequin

sagetrac-asalerno mannequin commented Jul 12, 2013

This function computes the p-adic Gamma function of a p-adic integer. This code is based on Pari code by Fernando Rodriguez-Villegas which uses an expansion due to Dwork.

Apply attachment: trac_14880_padic_gamma_v2.patch

Component: padics

Keywords: p-adic gamma, p-adic functions, dwork, SD53

Author: Beth Malmskog, Adriana Salerno, Christelle Vincent, Ursula Whitcher

Branch/Commit: u/asalerno/ticket/14880 @ 3b6a841

Reviewer: Volker Braun

Merged: sage-5.13.beta0

Issue created by migration from https://trac.sagemath.org/ticket/14880

@sagetrac-asalerno sagetrac-asalerno mannequin added this to the sage-5.12 milestone Jul 12, 2013
@fchapoton
Copy link
Contributor

Attachment: trac_14880_padic_gamma.patch.gz

@fchapoton

This comment has been minimized.

@fchapoton
Copy link
Contributor

comment:2

Attachment: trac_14880_padic_gamma_v2.patch.gz

your patch did not apply (seems to be some problem with the encoding of carriage returns)

so I used it to make a new one, with some corrections to the documentation formatting

for the bot:

apply only trac_14880_padic_gamma_v2.patch​

@fchapoton
Copy link
Contributor

comment:3

apply trac_14880_padic_gamma_v2.patch

@sagetrac-xguitart
Copy link
Mannequin

sagetrac-xguitart mannequin commented Sep 26, 2013

comment:4

When the algorithm is 'pari' it doesn't return an element in the p-adic ring:

sage: R = Zp(3)

sage: x = R(5).padic_gamma()

sage: x.parent()

Interface to the PARI C library

But coerce seems to work, so maybe just adding a coerce before returning the result will fix it:

sage: R(x).parent()

3-adic Ring with capped relative precision 20

@sagetrac-asalerno
Copy link
Mannequin Author

sagetrac-asalerno mannequin commented Sep 28, 2013

Branch: u/asalerno/ticket/14880

@vbraun
Copy link
Member

vbraun commented Sep 28, 2013

Commit: 3b6a841

@vbraun
Copy link
Member

vbraun commented Sep 28, 2013

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Sep 28, 2013

comment:7

Looks good to me

@vbraun
Copy link
Member

vbraun commented Sep 28, 2013

Changed keywords from p-adic gamma, p-adic functions, dwork to p-adic gamma, p-adic functions, dwork, SD53

@jdemeyer jdemeyer modified the milestones: sage-5.12, sage-5.13 Sep 29, 2013
@jdemeyer
Copy link

jdemeyer commented Oct 2, 2013

Merged: sage-5.13.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants