Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track all files in cliquer, and minor cleanup #14892

Closed
vbraun opened this issue Jul 15, 2013 · 10 comments
Closed

Track all files in cliquer, and minor cleanup #14892

vbraun opened this issue Jul 15, 2013 · 10 comments

Comments

@vbraun
Copy link
Member

vbraun commented Jul 15, 2013

Move untracked additions to the upstream sources to src/ as required for #14781

Spkg diff attachment: cliquer-p0-p1.diff

Component: packages: standard

Author: Volker Braun

Reviewer: Nathann Cohen

Merged: sage-5.12.beta1

Issue created by migration from https://trac.sagemath.org/ticket/14892

@vbraun
Copy link
Member Author

vbraun commented Jul 15, 2013

Initial patch

@vbraun
Copy link
Member Author

vbraun commented Jul 15, 2013

Attachment: trac_14892_cliquer_cleanup.patch.gz

Spkg diff for review purposes only

@vbraun

This comment has been minimized.

@vbraun
Copy link
Member Author

vbraun commented Jul 15, 2013

Author: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Jul 15, 2013

comment:1

Attachment: cliquer-p0-p1.diff.gz

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jul 15, 2013

comment:2

>_<

If we were japanese guys you would not have written such a patch, for it is shameful to me >_<

God. How did I write this thing in the first place ? Please forgive me >_<

Anyway, thank you very much ! This ADD_EDGE method looks useful indeed. And all tests pass, the sun shines and the birds sing outside.

Thaaaaaaaaaaaaaanks !

Nathann

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Jul 15, 2013

Reviewer: Nathann Cohen

@jdemeyer
Copy link

jdemeyer commented Aug 2, 2013

comment:4

Any reason why you use

for patch in `ls ../patches/*.patch`; do

instead of the standard

for patch in ../patches/*.patch; do

(both work correctly but the first wastes a process and will display a confusing error if no patch files are found)

@vbraun
Copy link
Member Author

vbraun commented Aug 2, 2013

comment:5

I switched the loop to the other syntax, updated spkg at the same place.

@jdemeyer
Copy link

Merged: sage-5.12.beta1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants