Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two small issues with make micro_release #14908

Closed
mezzarobba opened this issue Jul 18, 2013 · 11 comments
Closed

Two small issues with make micro_release #14908

mezzarobba opened this issue Jul 18, 2013 · 11 comments

Comments

@mezzarobba
Copy link
Member

A trivial patch to experiment with the git workflow...

  • the micro_release rule of the Makefile used |&, which is a bash4-ism
  • the filtering of error messages did not work in non-English locales

Component: build

Reviewer: Marc Mezzarobba, Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/14908

@mezzarobba mezzarobba added this to the sage-5.11 milestone Jul 18, 2013
@ohanar
Copy link
Member

ohanar commented Jul 19, 2013

comment:2

The working branch was a workaround until #14781 got resolved.

Please rebase against the build_system branch.

@mezzarobba
Copy link
Member Author

comment:3

Replying to @ohanar:

Please rebase against the build_system branch.

Done.

@vbraun
Copy link
Member

vbraun commented Sep 14, 2013

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Sep 14, 2013

comment:5

Looks good to me

@ohanar
Copy link
Member

ohanar commented Sep 16, 2013

comment:6

I've merged this into the build_system branch at #14480, so I'm marking this as a duplicate so that we can close this ticket now.

@ohanar ohanar removed this from the sage-6.0 milestone Sep 16, 2013
@mezzarobba
Copy link
Member Author

Changed branch from u/mmezzarobba/fix_micro_release to none

@mezzarobba
Copy link
Member Author

comment:7

Replying to @ohanar:

I've merged this into the build_system branch at #14480, so I'm marking this as a duplicate so that we can close this ticket now.

Ok, so I've deleted the branch and filled in the Commit field instead.

@mezzarobba
Copy link
Member Author

Commit: 0628ee3

@jdemeyer
Copy link

jdemeyer commented Oct 5, 2013

Changed commit from 0628ee3 to none

@jdemeyer
Copy link

jdemeyer commented Oct 5, 2013

Changed reviewer from Volker Braun to Marc Mezzarobba, Volker Braun

@jdemeyer
Copy link

jdemeyer commented Oct 5, 2013

Changed author from Marc Mezzarobba to none

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants