New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store actual tarball name in pkg metadata. #14968
Comments
Branch: u/robertwb/14968-tarballs |
comment:2
We could also support supporting a URL as the tarball field. That would be useful during development: people who cannot upload to the mirror network can then just put the upstream URL there. Actually, that might even make sense in general, not only during development. |
comment:3
Patch looks good to me. I don't think we should allow an arbitrary URL. Then we also have to make sure that every Sage release all URLs actually point to our servers. And for development its much easier to just put your tarball into the |
Reviewer: Volker Braun |
Author: Robert Bradshaw |
comment:5
So, now that this is positively reviewed, when/where does it get merged? |
Changed branch from u/robertwb/14968-tarballs to u/robertwb/ticket/14968 |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
Commit: |
comment:8
There were some merge conflicts. I've resolved those and improved the path a bit, please take another look (and hopefully merge before it goes stale again). |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
lgtm |
Changed branch from u/robertwb/ticket/14968 to u/vbraun/ticket/14968 |
comment:11
I fixed conflicts in r and git by merging with the newer version.... Last 10 new commits:
|
See discussion at https://groups.google.com/forum/#!topic/sage-git/Qkjey5OhVAo
Component: build
Author: Robert Bradshaw
Branch/Commit: u/vbraun/ticket/14968 @
b6b4adb
Reviewer: Volker Braun
Issue created by migration from https://trac.sagemath.org/ticket/14968
The text was updated successfully, but these errors were encountered: