Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store actual tarball name in pkg metadata. #14968

Closed
robertwb opened this issue Jul 25, 2013 · 16 comments
Closed

Store actual tarball name in pkg metadata. #14968

robertwb opened this issue Jul 25, 2013 · 16 comments

Comments

@robertwb
Copy link
Contributor

See discussion at https://groups.google.com/forum/#!topic/sage-git/Qkjey5OhVAo

Component: build

Author: Robert Bradshaw

Branch/Commit: u/vbraun/ticket/14968 @ b6b4adb

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/14968

@robertwb robertwb added this to the sage-6.0 milestone Jul 25, 2013
@robertwb
Copy link
Contributor Author

Branch: u/robertwb/14968-tarballs

@tkluck
Copy link

tkluck commented Jul 25, 2013

comment:2

We could also support supporting a URL as the tarball field. That would be useful during development: people who cannot upload to the mirror network can then just put the upstream URL there. Actually, that might even make sense in general, not only during development.

@vbraun
Copy link
Member

vbraun commented Jul 25, 2013

comment:3

Patch looks good to me.

I don't think we should allow an arbitrary URL. Then we also have to make sure that every Sage release all URLs actually point to our servers. And for development its much easier to just put your tarball into the /upstream directory instead of uploading it to a remote server and then downloading it again. It it turns out to be a crucial feature we can always add it later.

@vbraun
Copy link
Member

vbraun commented Jul 25, 2013

Reviewer: Volker Braun

@vbraun
Copy link
Member

vbraun commented Jul 25, 2013

Author: Robert Bradshaw

@robertwb
Copy link
Contributor Author

robertwb commented Aug 6, 2013

comment:5

So, now that this is positively reviewed, when/where does it get merged?

@robertwb
Copy link
Contributor Author

Changed branch from u/robertwb/14968-tarballs to u/robertwb/ticket/14968

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2013

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

[19382e1](https://github.com/sagemath/sagetrac-mirror/commit/19382e1)Add missing tarballs, use VERSION in tarball path.
[39080bf](https://github.com/sagemath/sagetrac-mirror/commit/39080bf)Allow VERSION variable in spkg tarball specification.
[652a892](https://github.com/sagemath/sagetrac-mirror/commit/652a892)Merge branch 'master' into 14968

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 13, 2013

Commit: 19382e1

@robertwb
Copy link
Contributor Author

comment:8

There were some merge conflicts. I've resolved those and improved the path a bit, please take another look (and hopefully merge before it goes stale again).

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2013

Changed commit from 19382e1 to f1ad358

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

[f1ad358](https://github.com/sagemath/sagetrac-mirror/commit/f1ad358)fix ppl tarball

@vbraun
Copy link
Member

vbraun commented Dec 1, 2013

comment:10

lgtm

@vbraun
Copy link
Member

vbraun commented Dec 16, 2013

Changed branch from u/robertwb/ticket/14968 to u/vbraun/ticket/14968

@vbraun
Copy link
Member

vbraun commented Dec 16, 2013

comment:11

I fixed conflicts in r and git by merging with the newer version....


Last 10 new commits:

[b6b4adb](https://github.com/sagemath/sagetrac-mirror/commit/b6b4adb)updated git checksum
[a25d736](https://github.com/sagemath/sagetrac-mirror/commit/a25d736)updated R checksum
[326f347](https://github.com/sagemath/sagetrac-mirror/commit/326f347)[FIXUP] 5.13.rc0: update git specific files
[c1cd99c](https://github.com/sagemath/sagetrac-mirror/commit/c1cd99c)Merge branch 'upstream' into u/ohanar/build_system
[fbb6305](https://github.com/sagemath/sagetrac-mirror/commit/fbb6305)5.13
[f6fcc98](https://github.com/sagemath/sagetrac-mirror/commit/f6fcc98)fixing git interface doctests for new git version
[4dd4da5](https://github.com/sagemath/sagetrac-mirror/commit/4dd4da5)Merge dev scripts branch since their doctests are changed by the new git
[f3df294](https://github.com/sagemath/sagetrac-mirror/commit/f3df294)update git to latest upstream version 1.8.4.4
[946b5b4](https://github.com/sagemath/sagetrac-mirror/commit/946b5b4)fix the commandline sage -dev script
[2941308](https://github.com/sagemath/sagetrac-mirror/commit/2941308)Use a DoctestSageDevWrapper for the global dev object during doctests

@vbraun
Copy link
Member

vbraun commented Dec 16, 2013

Changed commit from f1ad358 to b6b4adb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants