add recover_formula and prefix_to_infix functions to logicparser.py

[pscurek]

In the patch for this ticket, the functions recover_formula and prefix_to_infix are added to logicparser.py in the logic module. The function recover_formula allows for the recovery of a boolean formula from its parse tree. The function prefix_to_infix converts a parse tree from prefix form to infix form. Here are some examples.

sage: import sage.logic.logicparser as logicparser
sage: t = ['->', ['~', 'a'], ['|', 'c', ['~', 'd']]]
sage: logicparser.recover_formula(t)
'~a->(c|~d)'

sage: import sage.logic.logicparser as logicparser
sage: t = ['->', ['~', 'a'], ['|', 'c', ['~', 'd']]]
sage: logicparser.prefix_to_infix(t)
[['~', 'a'], '->', ['c', '|', ['~', 'd']]]

Depends on #14951
Depends on #14952
Depends on #15013

Component: misc

Keywords: logic, logicparser, prefix, infix

Author: Paul Scurek

Branch/Commit: 521ba42

Reviewer: Frédéric Chapoton, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/15018

[pscurek]

Attachment: trac_14951_tokenize_tree_fix.patch.gz

apply first

[pscurek]

Attachment: trac_14952_logic_if_while_syntax.patch.gz

apply second

[pscurek]

apply third

[williamstein]

comment:2

Attachment: trac_15013_logic_docstrings.patch.gz

Referee:

• trivial typo: "argrument" (in multiple places!)

• delete parens here: "prefix_to_infix() takes a parse tree as input"

• Someday somebody should change this... type(tree[1]) is ListType to isinstance(tree[1], list).

That's it.

[pscurek]

Apply this last. This is the patch for this ticket, but depends on the previous 3.

[pscurek]

Attachment: trac_15018_recover_formula.2.patch.gz

This file is the same as trac_15018_recover_formula.2.patch.

[pscurek]

comment:3

Attachment: trac_15018_recover_formula.patch.gz

I forgot to check the box for replacing the file with the same name. That is why there are attachments called trac_15018_recover_formula.patch and trac_15018_recover_formula.2.patch. They are exactly the same, so only apply one of them when testing the patch. I would get right of one of them, but I don't see an option for removing attachments.

[pscurek]

comment:5

The last patch listed in the attachments, trac_15018_recover_formula.patch, is the only patch that should be integrated into sage for this ticket. The first three patches are the patches from the dependencies for this ticket that were placed here for the convenience of the reviewer. The patch, trac_15018_recover_formula.2.patch is identical to trac_15018_recover_formula.patch.

[vbraun]

comment:6

First patch of the series does not apply any more, please fix.

[tscrim]

Commit: 86e7f6e

[tscrim]

Branch: public/ticket/15018

[tscrim]

comment:7

I've rebased this and made some minor doc changes. If everything is good, then positive review.

---

New commits:

9798dca	Trac 15018: added recover_formula, recover_formula_internal, prefix_to_infix, and to_infix_internal to logicparser.py
22ec476	Minor review tweaks.
bb23f1b	Merge branch 'develop' into public/ticket/15018
86e7f6e	Merge branch 'develop' into public/ticket/15018

[fchapoton]

Work Issues: needs rebase

[sagetrac-git]

Changed commit from 86e7f6e to b4e8f25

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b4e8f25

Merge branch 'public/ticket/15018' of trac.sagemath.org:sage into public/ticket/15018

[tscrim]

Changed work issues from needs rebase to none

[sagetrac-git]

Changed commit from b4e8f25 to 521ba42

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

521ba42

change raise syntax to python3 style

[fchapoton]

comment:14

looks good to me, positive review.

[fchapoton]

Reviewer: Frédéric Chapoton

[tscrim]

Changed reviewer from Frédéric Chapoton to Frédéric Chapoton, Travis Scrimshaw

[tscrim]

comment:15

Thanks Frederic.

[vbraun]

Changed branch from public/ticket/15018 to 521ba42