Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove import of is_* in matrix.all #15098

Closed
fchapoton opened this issue Aug 25, 2013 · 9 comments
Closed

remove import of is_* in matrix.all #15098

fchapoton opened this issue Aug 25, 2013 · 9 comments

Comments

@fchapoton
Copy link
Contributor

this is a follow-up of #15076

and a step towards #14329

Apply:

Depends on #15076

Component: linear algebra

Keywords: deprecation cleanup

Author: Frédéric Chapoton

Reviewer: Darij Grinberg

Merged: sage-5.13.beta3

Issue created by migration from https://trac.sagemath.org/ticket/15098

@fchapoton fchapoton added this to the sage-5.13 milestone Aug 25, 2013
@fchapoton
Copy link
Contributor Author

Author: Frédéric Chapoton

@darijgr
Copy link
Contributor

darijgr commented Nov 8, 2013

comment:4

Attachment: trac_15098_remove_global_is_in_matrix.patch.gz

I'm not quite sure what would constitute a review of this. How can a change like this cause any bugs if the doctests don't fail?

@fchapoton
Copy link
Contributor Author

comment:5

Yes, indeed. So this should be an easy thing to review..

@darijgr
Copy link
Contributor

darijgr commented Nov 10, 2013

Attachment: trac_15098_review-dg.patch.gz

@darijgr
Copy link
Contributor

darijgr commented Nov 10, 2013

comment:6

Great, this is done then. If you are OK with my changes, set this to positive_review.

for the patchbot:

apply trac_15098_remove_global_is_in_matrix.patch trac_15098_review-dg.patch​

@darijgr
Copy link
Contributor

darijgr commented Nov 10, 2013

Reviewer: Darij Grinberg

@darijgr

This comment has been minimized.

@fchapoton
Copy link
Contributor Author

comment:7

Thanks Darij !

I now set this to positive review.

@jdemeyer
Copy link

Merged: sage-5.13.beta3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants