Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python library, gmp vs mpir #15102

Closed
sagetrac-felixs mannequin opened this issue Aug 26, 2013 · 4 comments
Closed

python library, gmp vs mpir #15102

sagetrac-felixs mannequin opened this issue Aug 26, 2013 · 4 comments

Comments

@sagetrac-felixs
Copy link
Mannequin

sagetrac-felixs mannequin commented Aug 26, 2013

The sage python library includes gmp.h, but gmp.h (on Sage (the distribution)) is actually mpir.h. On other platforms things might look different.

Its probably best to use gmp_or_mpir.h provided by csage (part of #14726), to avoid confusion.

(There is no item "python-sage" in the Component dropdown. Hope "misc" is ok.)

Depends on #14726

CC: @jondo

Component: misc

Keywords: gmp mpir

Branch/Commit: u/felixs/gmp_or_mpir @ 4978388

Reviewer: Felix Salfelder

Issue created by migration from https://trac.sagemath.org/ticket/15102

@sagetrac-felixs sagetrac-felixs mannequin added this to the sage-6.1 milestone Aug 26, 2013
@jdemeyer jdemeyer removed this from the sage-6.1 milestone Dec 29, 2013
@jdemeyer
Copy link

jdemeyer commented Jul 1, 2015

comment:5

What's wrong with just keeping <gmp.h>? MPIR will install its header also as <gmp.h>, so you get the "correct" header no matter where GMP or MPIR was installed.

@jdemeyer
Copy link

jdemeyer commented Jul 1, 2015

Changed author from Felix Salfelder to none

@jdemeyer
Copy link

jdemeyer commented Jul 1, 2015

Reviewer: Felix Salfelder

@jpflori
Copy link

jpflori commented Jul 1, 2015

comment:6

I agree with Jeroen, we should close this ticket as invalid/won't fix.

On top of that, we can now build Sage on top of gmp and mpir indifferently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants