New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Projective Plane designs #15107
Comments
Branch: u/ncohen/15107 |
comment:2
Your code returns a very particular projective plane, the one obtained from the finite field of order n, whereas there could be many nonisomorphic ones (the first such case being n=9). This should be reflected in the docs, IMHO. |
comment:3
OKayyyyyyy. Branch updated |
comment:4
in
|
comment:5
Fixed ! Sorry 'bout that Nathann |
comment:6
Replying to @nathanncohen:
the function name is unfortunate; it should reflect the fact that there could be several examples, or, rather, make it unique, like |
comment:7
Well, I see a Plus I implemented a What would you think of this : we keep Combinat-style, this thing should be a new And if you insist I will rename this to Have fuuuuuuuuuuuuuuuuuuuuuuuun ! Nathann |
comment:8
http://en.wikipedia.org/wiki/Desargues%27_theorem is a geometric criterion satisfied by projective planes obtained from the 3-dimensional vector spaces over division rings; every finite division ring is a field, so in the finite case every such plane is Pappian, see http://en.wikipedia.org/wiki/Pappus%27s_hexagon_theorem. Keeping the current name sucks, as adding more examples would force you to rename stuff. As far as |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
comment:10
Cool automatic message Nathann |
comment:11
Replying to @nathanncohen:
By git... Perhaps the sage git dev scripts should get a better, more descriptive, name... Shlimazl, maybe :-) |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:13
Sorry Nathann, but what is exactly the purpose of the newfunction In my opinion, with this name, it does no longer make sense to answer 'No projective plane design of order 10 exists' or 'If such a projective plane exists, we do not know how to build it.' One should rather check if the input is a prime power and that's it. Then it would be just a restriction of ProjectiveGeometryDesign to the dimension 2, i.e. some kind of alias. Either this is considered not useful, and this ticket can be forgotten, or you want to keep it as an useful alias, and it will be ok. |
comment:14
Helloooooo ! Well, the purpose of this function is to return a projective plane design, i.e. a I agree with what you said. Actually, thinking about it again, I don't agree with what Dima said above. I don't see the problem with calling this What do you think ? I think that this alias is useful, but I personally spent quite some time trying to figure out of to obtain a projective plane design with Sage. Nathann |
comment:16
I just updated this ticket after the englightening discussion held on sage-devel : We now have an additional argument to ProjectivePlaneDesign which does nothing. That's for the sake of art. Nathann |
comment:17
There is a typo "afinite projective plane" I propose to replace "No other value is available for this parameter." by "For the moment, no other value is available for this parameter." |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:19
Here it is ! I updated the last commit Nathann |
Reviewer: Stefan van Zwam |
comment:20
I think this looks fine and is ready to go in. Just for fun, I did the following additional consistency check:
|
Shortcut to another function. In order to save a stranger the time it took me to understand it
:-P
Nathann
CC: @dimpase
Component: combinatorics
Author: Nathann Cohen
Branch/Commit: u/ncohen/15107 @
6f247f6
Reviewer: Stefan van Zwam
Issue created by migration from https://trac.sagemath.org/ticket/15107
The text was updated successfully, but these errors were encountered: