Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to RSK #15142

Closed
tscrim opened this issue Sep 2, 2013 · 11 comments
Closed

Changes to RSK #15142

tscrim opened this issue Sep 2, 2013 · 11 comments

Comments

@tscrim
Copy link
Collaborator

tscrim commented Sep 2, 2013

This is a followup to #8392 which will do the following:

  • Undeprecate the robinson_schensted() method for permutations.
  • Add a robinson_schensted() method for words and integer matrices and anything else that should be accepted as input into RSK.
  • Improve the documentation on the RSK function.

Apply: attachment: trac_15142-rsk_fixes-ts.patch

CC: @sagetrac-sage-combinat @anneschilling @saliola @darijgr

Component: combinatorics

Author: Travis Scrimshaw

Reviewer: Anne Schilling, Darij Grinberg

Merged: sage-5.13.beta0

Issue created by migration from https://trac.sagemath.org/ticket/15142

@darijgr
Copy link
Contributor

darijgr commented Sep 3, 2013

Attachment: trac_15142-review-dg.patch.gz

this is barely worth a patch, but here it is. set to positive_review if you agree.

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 4, 2013

comment:2

Anne, here's the patch with the change we talked about along with Darij's fixes.

Thanks for noticing those Darij.

For patchbot:

Apply: trac_15142-rsk_fixes-ts.patch

@anneschilling
Copy link

comment:3

Hi Travis,

Please change the following:

  • In the documentation of robinson-schensted in finite_words it says
   Return the pair of semistandard tableaux obtained by running the
   Robinson-Schensted algorithm on ``self``.

However, the recording tableau in this case is always standard and not semistandard!

  • Please add some tests to show that RSK and its inverse are indeed inverses. Make a comment in the documentation about the unusual input conventions which prevents RSK_inverse(RSK(..)) to be the identity!

Happy birthday!

Anne

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 5, 2013

Attachment: trac_15142-rsk_fixes-ts.patch.gz

@tscrim

This comment has been minimized.

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 5, 2013

comment:4

Hey Anne,

Done. I also changed the output from EG insertion to a list which is how reduced words are represented.

Thank you in advance; my birthday is tomorrow (well, at least tomorrow in most of North America).

For patchbot:

Apply: trac_15142-rsk_fixes-ts.patch

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 5, 2013

Reviewer: Anne Schilling, Darij Grinberg

@anneschilling
Copy link

comment:5

Darij, could you do the final technical review?

Thanks,

Anne

@darijgr
Copy link
Contributor

darijgr commented Sep 7, 2013

comment:6

Oops! For some reason this ticket wasn't sending me any emails. Just found it on the needing-review list...

Yes, the patch is fine, at least assuming that noone would want inverse Edelman-Greene RSK to return anything other than words (at least the original authors seem to use it on words only).

Happy birthday, Travis, if this still applies.

@tscrim
Copy link
Collaborator Author

tscrim commented Sep 7, 2013

comment:7

I'll count it. Thank you Darij.

@jdemeyer jdemeyer modified the milestones: sage-5.12, sage-5.13 Sep 26, 2013
@jdemeyer
Copy link

jdemeyer commented Oct 2, 2013

Merged: sage-5.13.beta0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants