Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix various issues with #1239 #1524

Closed
williamstein opened this issue Dec 15, 2007 · 1 comment
Closed

fix various issues with #1239 #1524

williamstein opened this issue Dec 15, 2007 · 1 comment

Comments

@williamstein
Copy link
Contributor

[12:01am] cwitty-rvw-1473: and you're confident that incidentally merging the extcode patches from 1239 doesn't hurt anything?
[12:01am] wstein-1183: yes.
[12:01am] wstein-1183: wait!
[12:02am] wstein-1183: It will completely break things
[12:02am] wstein-1183: I.e., it will break simon 2 descent
[12:02am] wstein-1183: however, I think robert is fixing the updated simon 2 descent now.
[12:02am] wstein-1183: There is nothing truly broken about that -- it just needs some polish.
[12:02am] wstein-1183: So I would recommend merging 1472 and 1239, but opening a ticket to polish 1239.
[12:03am] wstein-1183: Since 1239 works.
[12:03am] wstein-1183: it's just easy to get lies from some of the new functions 
[12:03am] jkantor: linking may be fine, but that would be about all . . .
[12:04am] cwitty-rvw-1473: Sounds good to me.  Do you want to change your review of 1239, and open the new ticket?
[12:04am] wstein-1183: yes

Component: number theory

Issue created by migration from https://trac.sagemath.org/ticket/1524

@williamstein williamstein added this to the sage-2.9 milestone Dec 15, 2007
@williamstein williamstein self-assigned this Dec 15, 2007
@robertwb
Copy link
Contributor

comment:1

This was resolved in #1239 after all...

@sagetrac-mabshoff sagetrac-mabshoff mannequin removed this from the sage-2.9 milestone Dec 15, 2007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants