Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

matroids.Uniform(r,r) returns wrong matroid #15292

Closed
sagetrac-Stefan mannequin opened this issue Oct 16, 2013 · 7 comments
Closed

matroids.Uniform(r,r) returns wrong matroid #15292

sagetrac-Stefan mannequin opened this issue Oct 16, 2013 · 7 comments
Labels
c: matroid theory p: minor / 4 t: bug
Milestone
sage-6.1

Comments

@sagetrac-Stefan
Copy link
Mannequin

sagetrac-Stefan mannequin commented Oct 16, 2013

The following is wrong:

sage: M = matroids.Uniform(4,4)
sage: len(M.circuit_closures())
1
sage: N = matroids.Uniform(4,5).delete(4)
sage: len(N.circuit_closures())
0
sage: N.is_isomorphic(M)
True

Component: matroid theory

Author: Rudi Pendavingh

Branch/Commit: u/Rudi/ticket/15292 @ a8a28c7

Reviewer: Stefan van Zwam

Issue created by migration from https://trac.sagemath.org/ticket/15292
@sagetrac-Stefan sagetrac-Stefan mannequin added this to the sage-6.1 milestone Oct 16, 2013
@sagetrac-Rudi
Copy link
Mannequin

sagetrac-Rudi mannequin commented Jan 3, 2014

Branch: u/Rudi/ticket/15292

@sagetrac-Rudi
Copy link
Mannequin

sagetrac-Rudi mannequin commented Jan 3, 2014

Commit: a8a28c7

@sagetrac-Rudi
Copy link
Mannequin

sagetrac-Rudi mannequin commented Jan 3, 2014

Author: Rudi Pendavingh

@sagetrac-Rudi
Copy link
Mannequin

sagetrac-Rudi mannequin commented Jan 3, 2014

New commits:

a8a28c7Fixed bug in uniform matroid.

@sagetrac-Rudi sagetrac-Rudi mannequin added the s: needs review label Jan 3, 2014
@sagetrac-Stefan
Copy link
Mannequin Author

sagetrac-Stefan mannequin commented Jan 3, 2014

comment:3

The code looks solid to me, a simple bug fix. Positive review!

@vbraun
Copy link
Member

vbraun commented Jan 4, 2014

Reviewer: Stefan van Zwam

@vbraun
Copy link
Member

vbraun commented Jan 4, 2014

comment:4

Please fill in reviewer name next time...

@vbraun vbraun closed this as completed in 9c9a8c6 Jan 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: matroid theory p: minor / 4 t: bug
Projects
None yet
Milestone
sage-6.1
Development

No branches or pull requests
1 participant
@vbraun