Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression in simplify_full #15362

Closed
zimmermann6 opened this issue Nov 6, 2013 · 5 comments
Closed

regression in simplify_full #15362

zimmermann6 opened this issue Nov 6, 2013 · 5 comments

Comments

@zimmermann6
Copy link

In Sage 5.12:

sage: e=log(1/2*sqrt(2)*(sqrt(2) + 1)) + log(1/2*sqrt(2)*(sqrt(2) - 1))
sage: e.simplify_full()
-log(2)
sage: (2*e).simplify_full()
2*log(1/2*sqrt(2)*(sqrt(2) + 1)) + 2*log(1/2*sqrt(2)*(sqrt(2) - 1))

In Sage 5.9 the last command gave instead:

sage: (2*e).simplify_full().simplify_full()
2*log(sqrt(2) - 1) + 2*log(sqrt(2) + 1) - 2*log(2)

This is related to #10983.

CC: @orlitzky

Component: calculus

Reviewer: Paul Zimmermann, Karl-Dieter Crisman

Issue created by migration from https://trac.sagemath.org/ticket/15362

@zimmermann6 zimmermann6 added this to the sage-5.13 milestone Nov 6, 2013
@kcrisman
Copy link
Member

kcrisman commented Nov 6, 2013

comment:1

I assume this stems from #12737? Just guessing.

@kcrisman
Copy link
Member

kcrisman commented Nov 6, 2013

comment:2

Indeed, in 5.12:

sage: (2*e).simplify_radical()
-2*log(2) + 2*log(sqrt(2) + 1) + 2*log(sqrt(2) - 1)

(Note the slight Pynac-related, unimportant, reordering.)

If I recall correctly, Paul was one of the bigger voices behind removing simplify_radical from full simplification, so hopefully #10983 can just change their doctest here.

@zimmermann6
Copy link
Author

comment:3

replacing simplify_full by simplify_radical indeed solves the two issues we have in #10983, and it is clearer.

I thus propose to close that ticket.

Paul

@kcrisman
Copy link
Member

kcrisman commented Nov 6, 2013

Reviewer: Paul Zimmermann, Karl-Dieter Crisman

@kcrisman
Copy link
Member

kcrisman commented Nov 6, 2013

comment:4

Okay, let's close this.

@kcrisman kcrisman removed this from the sage-5.13 milestone Nov 6, 2013
@jdemeyer jdemeyer closed this as completed Nov 9, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants