Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some cleanup in groups.<tab> #15368

Closed
nathanncohen mannequin opened this issue Nov 7, 2013 · 6 comments
Closed

Some cleanup in groups.<tab> #15368

nathanncohen mannequin opened this issue Nov 7, 2013 · 6 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Nov 7, 2013

Following the discussion at https://groups.google.com/d/msg/sage-devel/tyAxhqxk3ZI/SuBg2Ukwwj4J

I was about to say what this patch does, then noticed that it would naturally appear on the ticket as the commit messages of the new branch :-)

The reference manual page for groups looks like it could be reordered and made cleaner, but I know so few about groups that I am sure I would do it all wrong if I gave it a try ^^;

Nathann

CC: @vbraun @hivert @nthiery @videlec @jhpalmieri @kcrisman

Component: group theory

Author: Nathann Cohen

Branch/Commit: u/ncohen/15368 @ 0ad88a6

Reviewer: Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/15368

@nathanncohen nathanncohen mannequin added this to the sage-5.13 milestone Nov 7, 2013
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Nov 7, 2013

Branch: u/ncohen/15368

@nathanncohen nathanncohen mannequin added the s: needs review label Nov 7, 2013
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 7, 2013

Commit: 0ad88a6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 7, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

[0ad88a6](https://github.com/sagemath/sagetrac-mirror/commit/0ad88a6)Additions to groups.misc : AdditiveAbelian, Free, Braid, SemimonomialTransformation
[3d75bd3](https://github.com/sagemath/sagetrac-mirror/commit/3d75bd3)Move QuaternionMatrixGroupGF3 from groups.misc to groups.matrix
[2a68051](https://github.com/sagemath/sagetrac-mirror/commit/2a68051)Add affine groups to groups.
[017084f](https://github.com/sagemath/sagetrac-mirror/commit/017084f)Broken link in groups catalog doc

@vbraun
Copy link
Member

vbraun commented Nov 10, 2013

comment:3

Looks good to me.

@vbraun
Copy link
Member

vbraun commented Nov 10, 2013

Reviewer: Volker Braun

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Nov 10, 2013

comment:4

Thaaaaaaaaaaaaanks !!!

@jdemeyer jdemeyer modified the milestones: sage-5.13, sage-6.0 Nov 10, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.0, sage-6.1 Dec 17, 2013
@vbraun vbraun closed this as completed in 2382c12 Dec 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants