Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projective Point global_height remove special case for ZZ #15376

Closed
pfili opened this issue Nov 7, 2013 · 5 comments
Closed

Projective Point global_height remove special case for ZZ #15376

pfili opened this issue Nov 7, 2013 · 5 comments
Assignees
@pfili
Labels
c: algebraic geometry p: minor / 4 t: enhancement
Milestone
sage-5.13

Comments

@pfili
Copy link

pfili commented Nov 7, 2013

global_height in Projective Point needed to make a special case for computing the global height when defined over ZZ, as ZZ lacked global_height. global_height was implemented for ZZ in #15373, so this special case can be removed.

Depends on #15373

Component: algebraic geometry

Keywords: sage-days55

Author: Paul Fili

Reviewer: Adam Towsley

Merged: sage-5.13.beta4

Issue created by migration from https://trac.sagemath.org/ticket/15376
@pfili pfili added this to the sage-5.13 milestone Nov 7, 2013
@pfili
Copy link
Author

pfili commented Nov 8, 2013

Author: Paul Fili

@pfili pfili self-assigned this Nov 8, 2013
@sagetrac-atowsley
Copy link
Mannequin

sagetrac-atowsley mannequin commented Nov 9, 2013

comment:4

It passed the doc test and the long test.

Functionality still works.

@sagetrac-atowsley
Copy link
Mannequin

sagetrac-atowsley mannequin commented Nov 10, 2013

Reviewer: Adam Towsley

@pfili
Copy link
Author

pfili commented Nov 10, 2013

Attachment: trac_15376_use_ZZ_global_height.patch.gz

Removes special case for global height of ZZ in projective_point

@jdemeyer
Copy link

Merged: sage-5.13.beta4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pfili pfili

Labels
c: algebraic geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-5.13
Development

No branches or pull requests
2 participants
@jdemeyer @pfili