Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong output of %timeit #15398

Closed
zimmermann6 opened this issue Nov 11, 2013 · 18 comments
Closed

wrong output of %timeit #15398

zimmermann6 opened this issue Nov 11, 2013 · 18 comments

Comments

@zimmermann6
Copy link

sage: R=RealField(1000000)
sage: a=R(1/sqrt(3))
sage: %timeit a.arcsin()
1 loops, best of 3: 7.26 s per loop

It should be 1 loop, best of 3.

Upstream: Reported upstream. No feedback yet.

Component: user interface

Author: Saket Bhatt

Branch/Commit: bc52a1c

Reviewer: Paul Zimmermann

Issue created by migration from https://trac.sagemath.org/ticket/15398

@zimmermann6 zimmermann6 added this to the sage-6.1 milestone Nov 11, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@jdemeyer

This comment has been minimized.

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@Bhatt21
Copy link
Mannequin

Bhatt21 mannequin commented Feb 28, 2020

comment:5

pushed branch u/gh-Bhatt21/wrong_output_timeit to correct this issue in src/sage/misc/sage_timeit.py

@Bhatt21
Copy link
Mannequin

Bhatt21 mannequin commented Feb 28, 2020

Branch: u/gh-Bhatt21/wrong_output_timeit

@Bhatt21
Copy link
Mannequin

Bhatt21 mannequin commented Feb 28, 2020

Commit: bc52a1c

@Bhatt21
Copy link
Mannequin

Bhatt21 mannequin commented Feb 28, 2020

New commits:

bc52a1ctrac #15398 corrected sagetimeit grammar

@zimmermann6
Copy link
Author

comment:7

looks good to me, thanks. Please could you tick the "needs review" button?

@Bhatt21 Bhatt21 mannequin added the s: needs review label Feb 28, 2020
@zimmermann6
Copy link
Author

Reviewer: Paul Zimmermann

@zimmermann6
Copy link
Author

comment:9

please fill also the "Author" field.

@Bhatt21
Copy link
Mannequin

Bhatt21 mannequin commented Feb 28, 2020

Author: gh-Bhatt21

@zimmermann6
Copy link
Author

comment:11

looks good to me, thanks!

@jhpalmieri
Copy link
Member

comment:12

Please enter your real name in the author field.

@Bhatt21
Copy link
Mannequin

Bhatt21 mannequin commented Feb 28, 2020

Changed author from gh-Bhatt21 to Saket Bhatt

@fchapoton fchapoton modified the milestones: sage-6.4, sage-9.1 Feb 29, 2020
@Bhatt21
Copy link
Mannequin

Bhatt21 mannequin commented Mar 1, 2020

comment:15

can someone tell me why this particular test pyflakes failing. It says time imported but not used but that is not the part of modified lines.

@fchapoton
Copy link
Contributor

comment:16

as explained in the link on top of the patchbot report,

(https://wiki.sagemath.org/plugins#pyflakes)

pyflakes checks the modified files.

@Bhatt21
Copy link
Mannequin

Bhatt21 mannequin commented Mar 1, 2020

comment:17

thanks. so I should get rid of this particular pyflakes error by making a new commit right?

@fchapoton
Copy link
Contributor

comment:18

not necessarily, only if you can check that this removal does not break anything. It could be that "time" is imported from this file by another file, who knows..

@Bhatt21
Copy link
Mannequin

Bhatt21 mannequin commented Mar 1, 2020

comment:19

true

@vbraun
Copy link
Member

vbraun commented Mar 1, 2020

Changed branch from u/gh-Bhatt21/wrong_output_timeit to bc52a1c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants