New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wrong output of %timeit #15398
Comments
This comment has been minimized.
This comment has been minimized.
comment:5
pushed branch u/gh-Bhatt21/wrong_output_timeit to correct this issue in src/sage/misc/sage_timeit.py |
Branch: u/gh-Bhatt21/wrong_output_timeit |
Commit: |
New commits:
|
comment:7
looks good to me, thanks. Please could you tick the "needs review" button? |
Reviewer: Paul Zimmermann |
comment:9
please fill also the "Author" field. |
Author: gh-Bhatt21 |
comment:11
looks good to me, thanks! |
comment:12
Please enter your real name in the author field. |
Changed author from gh-Bhatt21 to Saket Bhatt |
comment:15
can someone tell me why this particular test pyflakes failing. It says time imported but not used but that is not the part of modified lines. |
comment:16
as explained in the link on top of the patchbot report, (https://wiki.sagemath.org/plugins#pyflakes) pyflakes checks the modified files. |
comment:17
thanks. so I should get rid of this particular pyflakes error by making a new commit right? |
comment:18
not necessarily, only if you can check that this removal does not break anything. It could be that "time" is imported from this file by another file, who knows.. |
comment:19
true |
Changed branch from u/gh-Bhatt21/wrong_output_timeit to |
It should be
1 loop, best of 3
.Upstream: Reported upstream. No feedback yet.
Component: user interface
Author: Saket Bhatt
Branch/Commit:
bc52a1c
Reviewer: Paul Zimmermann
Issue created by migration from https://trac.sagemath.org/ticket/15398
The text was updated successfully, but these errors were encountered: