Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R package doesn't notice if rpy fails to build #1542

Closed
craigcitro opened this issue Dec 17, 2007 · 3 comments
Closed

R package doesn't notice if rpy fails to build #1542

craigcitro opened this issue Dec 17, 2007 · 3 comments

Comments

@craigcitro
Copy link
Member

I think the title says it all; the issue is that no return value is checked, so R doesn't know that anything is wrong. The attached patch just adds a check in spkg-install to make sure everything went okay with the rpy install.

Component: packages: standard

Issue created by migration from https://trac.sagemath.org/ticket/1542

@craigcitro craigcitro added this to the sage-2.9.1 milestone Dec 17, 2007
@craigcitro craigcitro self-assigned this Dec 17, 2007
@craigcitro
Copy link
Member Author

comment:1

The patch is against r-2.6.1.p6.spkg (I forgot to mention that above, though it probably goes without saying).

@craigcitro
Copy link
Member Author

comment:3

Attachment: 1542.patch.gz

Posted new version of the patch, which reflects the updated name for the rpy-1.0.1.p0.spkg. (I also added a variable so that the rpy spkg name only appears once, instead of twice, making it less likely that someone would accidentally change one and not the other.)

@rlmill
Copy link
Mannequin

rlmill mannequin commented Dec 18, 2007

comment:4

Merged in 2.9.1.alpha1

@rlmill rlmill mannequin closed this as completed Dec 18, 2007
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant