Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Borken git doctests. #15420

Closed
robertwb opened this issue Nov 14, 2013 · 14 comments
Closed

Borken git doctests. #15420

robertwb opened this issue Nov 14, 2013 · 14 comments

Comments

@robertwb
Copy link
Contributor

Github master, at 094712a (head)

http://patchbot.sagemath.org/log/0/Ubuntu/12.10/x86_64/3.5.0-17-generic/pi/2013-11-14%2002:54:22%20-0800?short

Looks like we just need to sort this list.

CC: @ohanar

Component: misc

Author: Robert Bradshaw, R. Andrew Ohana

Branch/Commit: u/ohanar/ticket/15420 @ 2e77868

Reviewer: R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/15420

@robertwb robertwb added this to the sage-6.0 milestone Nov 14, 2013
@robertwb
Copy link
Contributor Author

Branch: u/robertwb/ticket/15420

@robertwb
Copy link
Contributor Author

Commit: 5f2cbc3

@robertwb
Copy link
Contributor Author

Author: Robert Bradshaw

@robertwb
Copy link
Contributor Author

New commits:

[5f2cbc3](https://github.com/sagemath/sagetrac-mirror/commit/5f2cbc3)Sort output for doctests.

@ohanar
Copy link
Member

ohanar commented Nov 14, 2013

comment:3

The docstring says it should be sorted by last commit time, and the code looks like it does that, so sorting the output (alphabetically) is wrong. Really we should spoof the commit time using an environment variable (it is something like GIT_COMMITTER_DATE), rather than using time.sleep.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 15, 2013

Changed commit from 5f2cbc3 to e977e69

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 15, 2013

Branch pushed to git repo; I updated commit sha1. This was a forced push. Recent commits:

e977e69 Use explicit date for git doctests.

@robertwb
Copy link
Contributor Author

comment:5

Ah, yes. Fixed to set the date.

@ohanar
Copy link
Member

ohanar commented Nov 15, 2013

Changed branch from u/robertwb/ticket/15420 to u/ohanar/ticket/15420

@ohanar
Copy link
Member

ohanar commented Nov 15, 2013

Reviewer: R. Andrew Ohana

@ohanar
Copy link
Member

ohanar commented Nov 15, 2013

Changed commit from e977e69 to 2e77868

@ohanar
Copy link
Member

ohanar commented Nov 15, 2013

comment:6

Seems like os.environ is ignored (at least on my system). I changed the doctest to explicitly set the environment. Otherwise, positive review.


New commits:

[2e77868](https://github.com/sagemath/sagetrac-mirror/commit/2e77868)specify environment explicitly for doctests

@ohanar
Copy link
Member

ohanar commented Nov 15, 2013

Changed author from Robert Bradshaw to Robert Bradshaw, R. Andrew Ohana

@robertwb
Copy link
Contributor Author

comment:7

Interesting. Your change looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants