GP interface confused by stack overflow when enlarging results vector

[pjbruin]

From Georgi Guninski on sage-support (https://groups.google.com/forum/#!topic/sage-support/A_GilhiUAwM):

sage: gp("{T(n)=n+1}")
sage: for n in [ 1 .. 2**20]:
    a=gp.T(n)
    print n

#wait some time..
...
65535
65536
---------------------------------------------------------------------------
TypeError

TypeError: Error executing code in GP:
CODE:
        sage[131074]=65537;
PARI/GP ERROR:
  ***   at top-level: sage[131074]=65537
  ***                     ^--------------
  ***   array index (131074) out of allowed range [1-131073].

after this trying:

sage: gp.T(1)

again raises exception.

After the above computation, the log file .sage/gp-expect.log ends with

? sage[131070]=65535;
sage[131070]=65535;
? sage[131071]=T(sage[131070]);
sage[131071]=T(sage[131070]);
? sage=concat(sage, vector(131072,k,0));
sage=concat(sage, vector(131072,k,0));
  ***   at top-level: sage=concat(sage,vec
  ***                 ^--------------------
  ***   the PARI stack overflows !
  current stack size: 10000000 (9.537 Mbytes)
  [hint] you can increase GP stack with allocatemem()

? allocatemem()
allocatemem()
  ***   Warning: new stack size = 20000000 (19.073 Mbytes).
? sage=concat(sage, vector(131072,k,0));
sage=concat(sage, vector(131072,k,0));
? sage[131072]=65536;
sage[131072]=65536;
? sage[131073]=T(sage[131072]);
sage[131073]=T(sage[131072]);
? sage[131074]=65537;
sage[131074]=65537;
  ***   at top-level: sage[131074]=65537
  ***                     ^--------------
  ***   array index (131074) out of allowed range [1-131073].
?

It appears that the vector sage wasn't doubled correctly; probably it got messed up by the failed concat().

This could be related to #11017/#11018.

Component: interfaces

Keywords: gp stack overflow

Author: Peter Bruin

Branch/Commit: ab293b2

Reviewer: Alejandro Argaez

Issue created by migration from https://trac.sagemath.org/ticket/15446

[pjbruin]

Commit: ab293b2

[pjbruin]

comment:2

The problem appears to be fixed by introducing a temporary variable to hold the result of concat() instead of directly assigning it to sage.

[pjbruin]

Author: Peter Bruin

[pjbruin]

Branch: u/pbruin/15446-gp_results_vector

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

229fd4c

use separate variables instead of a vector for GP results

[sagetrac-git]

Changed commit from ab293b2 to 229fd4c

[pjbruin]

comment:4

Never mind the commit in comment:3, this breaks when there are more than 65535 variables.

[sagetrac-git]

Changed commit from 229fd4c to ab293b2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ab293b2

fix resizing of GP results vector when stack overflow occurs

[pjbruin]

comment:7

Alejandro, could you fill in your name (more precisely your real name, not Trac username) in the "Reviewer" field?

[sagetrac-ArgaezG]

Reviewer: Alejandro Argaez

[vbraun]

Changed branch from u/pbruin/15446-gp_results_vector to ab293b2