You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In devel/sage/sage/matrix/matrix_integer_dense.pyx, wrap IML calls in _solve_iml() in sig_on()/sig_off().
The patch also changes the exception type for non-square matrices from ArithmeticError to ValueError, since that's just a limitation of the implementation, it's not a mathematical obstruction.
patch looks good and passes test. However, can you document the fact that you changed the exception in the ticket's description. After that, it's an automatic positive review.
In
devel/sage/sage/matrix/matrix_integer_dense.pyx
, wrap IML calls in_solve_iml()
insig_on()
/sig_off()
.The patch also changes the exception type for non-square matrices from
ArithmeticError
toValueError
, since that's just a limitation of the implementation, it's not a mathematical obstruction.Depends on #13311
CC: @malb
Component: linear algebra
Author: Jeroen Demeyer
Reviewer: Martin Albrecht
Merged: sage-5.13.beta5
Issue created by migration from https://trac.sagemath.org/ticket/15453
The text was updated successfully, but these errors were encountered: