Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap IML calls in sig_on() #15453

Closed
jdemeyer opened this issue Nov 25, 2013 · 5 comments
Closed

Wrap IML calls in sig_on() #15453

jdemeyer opened this issue Nov 25, 2013 · 5 comments

Comments

@jdemeyer
Copy link

In devel/sage/sage/matrix/matrix_integer_dense.pyx, wrap IML calls in _solve_iml() in sig_on()/sig_off().

The patch also changes the exception type for non-square matrices from ArithmeticError to ValueError, since that's just a limitation of the implementation, it's not a mathematical obstruction.

Depends on #13311

CC: @malb

Component: linear algebra

Author: Jeroen Demeyer

Reviewer: Martin Albrecht

Merged: sage-5.13.beta5

Issue created by migration from https://trac.sagemath.org/ticket/15453

@jdemeyer jdemeyer added this to the sage-5.13 milestone Nov 25, 2013
@jdemeyer
Copy link
Author

Dependencies: #13311

@malb
Copy link
Member

malb commented Nov 26, 2013

Reviewer: Martin Albrecht

@malb
Copy link
Member

malb commented Nov 26, 2013

comment:2

Attachment: 15453_iml_sig_on.patch.gz

patch looks good and passes test. However, can you document the fact that you changed the exception in the ticket's description. After that, it's an automatic positive review.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

jdemeyer commented Dec 5, 2013

Merged: sage-5.13.beta5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants