Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up interface to the PARI library, II #15461

Closed
pjbruin opened this issue Nov 27, 2013 · 9 comments
Closed

Clean up interface to the PARI library, II #15461

pjbruin opened this issue Nov 27, 2013 · 9 comments

Comments

@pjbruin
Copy link
Contributor

pjbruin commented Nov 27, 2013

After #15185, the following changes are made in this ticket:

  • The gen class currently contains duplicates of various methods of PariInstance (such as new_gen) for no obvious reason. These methods will be deleted.

  • Remove obsolete code (e.g. add_unsafe, which currently is not used, and probably never should be).

Depends on #15185

CC: @jdemeyer

Component: interfaces

Keywords: pari

Author: Peter Bruin

Branch/Commit: u/pbruin/15461_clean_up_pari_interface @ 5bb8f8d

Reviewer: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/15461

@pjbruin pjbruin added this to the sage-6.1 milestone Nov 27, 2013
@pjbruin

This comment has been minimized.

@pjbruin
Copy link
Contributor Author

pjbruin commented Dec 11, 2013

@pjbruin
Copy link
Contributor Author

pjbruin commented Dec 11, 2013

Commit: 5bb8f8d

@pjbruin
Copy link
Contributor Author

pjbruin commented Dec 11, 2013

comment:4

This branch only deletes obsolete stuff and makes the minimal changes necessary to keep everything working. I think further (non-trivial) changes should probably wait until a different ticket.


Last 10 new commits:

[5bb8f8d](https://github.com/sagemath/sagetrac-mirror/commit/5bb8f8d)remove commented-out method gen.python()
[3fa4f1d](https://github.com/sagemath/sagetrac-mirror/commit/3fa4f1d)remove redundant methods from sage.libs.pari.gen
[511f05b](https://github.com/sagemath/sagetrac-mirror/commit/511f05b)remove global variable mytop
[866f7fd](https://github.com/sagemath/sagetrac-mirror/commit/866f7fd)remove methods sage.libs.pari.gen.*_unsafe
[05b93b7](https://github.com/sagemath/sagetrac-mirror/commit/05b93b7)remove "pbw" as an abbreviation for "prec_bits_to_words"
[95a622a](https://github.com/sagemath/sagetrac-mirror/commit/95a622a)better fix for real_double.pyx
[11a3bfb](https://github.com/sagemath/sagetrac-mirror/commit/11a3bfb)more fixes related to relocation of PariInstance
[34013cc](https://github.com/sagemath/sagetrac-mirror/commit/34013cc)fixes in sage.libs.pari
[db8cd7e](https://github.com/sagemath/sagetrac-mirror/commit/db8cd7e)top-level changes related to PariInstance
[fcf7972](https://github.com/sagemath/sagetrac-mirror/commit/fcf7972)adapt miscellaneous files in the Sage library

@jdemeyer
Copy link

Author: Peter Bruin

@jdemeyer
Copy link

Reviewer: Jeroen Demeyer

@jdemeyer
Copy link

comment:5

I think you should also remove the global variable prec from gen.pyx and replace prec by calls to prec_bits_to_words() (without argument).

@jdemeyer
Copy link

comment:6

Or that could go to a new ticket...

@jdemeyer
Copy link

comment:7

See #15523.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants