Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finite Words should be proud of their finiteness #15479

Closed
nathanncohen mannequin opened this issue Dec 3, 2013 · 7 comments
Closed

Finite Words should be proud of their finiteness #15479

nathanncohen mannequin opened this issue Dec 3, 2013 · 7 comments

Comments

@nathanncohen
Copy link
Mannequin

nathanncohen mannequin commented Dec 3, 2013

Right now :

sage: Words(2,infinite=False)                               
Words over {1, 2}

Instead of

sage: Words(2, infinite=False)
Finite Words over {1, 2}

Nathann

CC: @seblabbe @videlec @sagetrac-sage-combinat @saliola

Component: combinatorics

Author: Nathann Cohen

Branch/Commit: u/ncohen/15479 @ 8c2aeff

Reviewer: Andrew Mathas

Issue created by migration from https://trac.sagemath.org/ticket/15479

@nathanncohen nathanncohen mannequin added this to the sage-6.0 milestone Dec 3, 2013
@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 3, 2013

Branch: u/ncohen/15479

@nathanncohen nathanncohen mannequin added the s: needs review label Dec 3, 2013
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 3, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

[8c2aeff](https://github.com/sagemath/sagetrac-mirror/commit/8c2aeff)trac #15479: Finite Words should be proud of their finiteness

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 3, 2013

Commit: 8c2aeff

@nathanncohen

This comment has been minimized.

@AndrewMathas
Copy link
Member

comment:4

Trivial but useful change, especially since infinite words were already proud.

Positive review.

[I'm on a roll:)]

@AndrewMathas
Copy link
Member

Reviewer: Andrew Mathas

@nathanncohen
Copy link
Mannequin Author

nathanncohen mannequin commented Dec 6, 2013

comment:5

Trivial but useful change, especially since infinite words were already proud.

Positive review.

[I'm on a roll:)]

Ahahahahah. Yeah, a great kind of roll :-D

Thaaaaanks !

Nathann

@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.0, sage-6.1 Dec 17, 2013
@vbraun vbraun closed this as completed in 59f05bd Dec 20, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants