New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_integer method is missing on integers #15500
Comments
Branch: u/Rajesh_Veeranki/ticket/15500 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Commit: |
comment:4
This needs more work actually, so that other fields also give proper results. For example:
and so on.. The correct fix in those fields would be either to have a function alias if
or have a code like this in that field
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:6
Hi Rajesh, seems like you are a new developer to Sage. I think this is a good ticket for you since it will need you to go through many different field implementations and introduce this small method into them. You do not need to make all the changes in one go. You can add a new commit, introducing the method in a different field. At the end when you do When you are done making the changes, you should set the status of the ticket to "needs review". This can be done from the command line using the following command when your branch is
Alternatively, you can log in to trac via the browser and set it yourself. If you log in to trac via the browser you can also set your author name in the author field of the ticket. This should match your author name in git, which I noticed you have set up properly. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
Hi ppurka, I'm a final year CSE student from IITB and new to the dev process.Thanks for guiding me. P.S: |
comment:11
Thanks for the patches! There are two doctest failures. It needs a bit more work. We will also have to check that it does not affect anything else adversely:
|
comment:12
Also, in
inside the class Edit: Sorry, it looks like I myself wrote the comment:4 ambiguously. What I meant was to use the above line if |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
Hi Punarbasu, I've incorporated the suggested changes.The doc-tests
have passed.Please review again and give suggestions.Thanks! |
comment:15
Looks good to me now. Thanks! :) |
Author: Rajesh Veeranki |
Reviewer: Punarbasu Purkayastha |
comment:16
There is some mis-formatting. There should be an empty line after
and before
|
comment:17
Also, it is discouraged to start doctests with
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Changed branch from u/Rajesh_Veeranki/ticket/15500 to u/ppurka/ticket/15500 |
comment:21
Didn't notice the update by Rajesh several weeks ago. Merged 6.2.beta8. New commits:
|
Changed reviewer from Punarbasu Purkayastha to Punarbasu Purkayastha, Jeroen Demeyer |
Changed branch from u/ppurka/ticket/15500 to |
From google spreadsheet which no one reads
X-(
Instead integers have
is_integral
.Component: algebra
Author: Rajesh Veeranki
Branch/Commit:
4d00b30
Reviewer: Punarbasu Purkayastha, Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/15500
The text was updated successfully, but these errors were encountered: