Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maxima takes version information from git repo #15529

Closed
vbraun opened this issue Dec 17, 2013 · 10 comments
Closed

Maxima takes version information from git repo #15529

vbraun opened this issue Dec 17, 2013 · 10 comments
Labels
c: build p: blocker / 1 t: bug
Milestone
sage-6.0

Comments

@vbraun
Copy link
Member

vbraun commented Dec 17, 2013

Maxima's configure.in checks if it is being run from a git repo, and if so then it uses git describe --dirty as maxima version.

Component: build

Author: Volker Braun

Branch/Commit: u/vbraun/maxima_git_version @ 148fc58

Reviewer: R. Andrew Ohana

Issue created by migration from https://trac.sagemath.org/ticket/15529
@vbraun vbraun added this to the sage-6.0 milestone Dec 17, 2013
@ohanar
Copy link
Member

ohanar commented Dec 17, 2013

comment:1

Maybe add export GIT_DIR="$(pwd)/.git" right before configuring maxima?

@vbraun
Copy link
Member Author

vbraun commented Dec 17, 2013

Branch: u/vbraun/maxima_git_version

@vbraun
Copy link
Member Author

vbraun commented Dec 17, 2013

Author: Volker Braun

@vbraun
Copy link
Member Author

vbraun commented Dec 17, 2013

New commits:

[8f43b28](https://github.com/sagemath/sagetrac-mirror/commit/8f43b28)Disable Maximas version-from-git feature

@vbraun
Copy link
Member Author

vbraun commented Dec 17, 2013

Commit: 8f43b28

@ohanar
Copy link
Member

ohanar commented Dec 17, 2013

comment:4

Probably want to increment patch version, otherwise looks good.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 17, 2013

Branch pushed to git repo; I updated commit sha1. New commits:

[148fc58](https://github.com/sagemath/sagetrac-mirror/commit/148fc58)bump patchlevel to trigger maxima recompilation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 17, 2013

Changed commit from 8f43b28 to 148fc58

@vbraun
Copy link
Member Author

vbraun commented Dec 17, 2013

comment:6

Done

@vbraun
Copy link
Member Author

vbraun commented Dec 17, 2013

Reviewer: R. Andrew Ohana

@vbraun vbraun closed this as completed in 3cf92ba Dec 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-6.0
Development

No branches or pull requests
2 participants
@vbraun @ohanar