Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change EMBEDDED_MODE and DOCTEST_MODE to functions #15557

Closed
jdemeyer opened this issue Dec 20, 2013 · 3 comments
Closed

Change EMBEDDED_MODE and DOCTEST_MODE to functions #15557

jdemeyer opened this issue Dec 20, 2013 · 3 comments
Labels
r: invalid t: enhancement

Comments

@jdemeyer
Copy link

Right now, EMBEDDED_MODE is defined in many places and DOCTEST_MODE is defined in sage.doctest.

This ticket will change these variables to functions embedded_mode() and doctest_mode() in a new file sage/modes.py.

CC: @vbraun

Component: misc

Author: Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/15557
@jdemeyer jdemeyer added this to the sage-6.1 milestone Dec 20, 2013
@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer jdemeyer changed the title Unify EMBEDDED_MODE Unify EMBEDDED_MODE and DOCTEST_MODE Dec 20, 2013
@jdemeyer jdemeyer changed the title Unify EMBEDDED_MODE and DOCTEST_MODE Change EMBEDDED_MODE and DOCTEST_MODE to functions Dec 20, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@novoselt
Copy link
Member

comment:6

Note also that Sage Cell changes it to a dictionary in sage.misc.misc:
novoselt/sage@dc6fa50
It would be nice to coordinate further changes to prevent divergence. Or perhaps live things as is and instead become UI agnostic as Volker suggests in #16995 comment:3

@novoselt
Copy link
Member

comment:7

With the new display system there should be no such things at all!

@novoselt novoselt removed this from the sage-6.4 milestone Aug 22, 2015
@vbraun vbraun closed this as completed Mar 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
r: invalid t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vbraun @tscrim @novoselt @jdemeyer